From: Fam Zheng <famz@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] file-posix: Use error API properly
Date: Thu, 1 Nov 2018 14:27:41 +0800 [thread overview]
Message-ID: <20181101062741.GA17770@magic> (raw)
In-Reply-To: <87va5irwxi.fsf@dusky.pond.sub.org>
On Wed, 10/31 15:51, Markus Armbruster wrote:
> Fam Zheng <famz@redhat.com> writes:
>
> > Use error_report for situations that affect user operation (i.e. we're
> > actually returning error), and warn_report/warn_report_err when some
> > less critical error happened but the user operation can still carry on.
> >
> > For raw_normalize_devicepath, add Error parameter to propagate to
> > its callers.
> >
> > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> Kevin, if you'd prefer this to go through my tree, let me know.
Thanks for the review. I'll respin and use error_setg_errno as suggested by
Eric, if it's okay.
Fam
next prev parent reply other threads:[~2018-11-01 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 5:39 [Qemu-devel] [PATCH v2] file-posix: Use error API properly Fam Zheng
2018-10-31 14:51 ` Markus Armbruster
2018-11-01 6:27 ` Fam Zheng [this message]
2018-10-31 14:57 ` Eric Blake
2018-10-31 16:05 ` Philippe Mathieu-Daudé
2018-10-31 16:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101062741.GA17770@magic \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).