From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI6SN-0005ky-1L for qemu-devel@nongnu.org; Thu, 01 Nov 2018 02:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gI6SM-0006gI-7Q for qemu-devel@nongnu.org; Thu, 01 Nov 2018 02:27:50 -0400 Date: Thu, 1 Nov 2018 14:27:41 +0800 From: Fam Zheng Message-ID: <20181101062741.GA17770@magic> References: <20181031053920.7565-1-famz@redhat.com> <87va5irwxi.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87va5irwxi.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v2] file-posix: Use error API properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Max Reitz On Wed, 10/31 15:51, Markus Armbruster wrote: > Fam Zheng writes: > > > Use error_report for situations that affect user operation (i.e. we're > > actually returning error), and warn_report/warn_report_err when some > > less critical error happened but the user operation can still carry on. > > > > For raw_normalize_devicepath, add Error parameter to propagate to > > its callers. > > > > Suggested-by: Markus Armbruster > > Signed-off-by: Fam Zheng > > Reviewed-by: Markus Armbruster > > Kevin, if you'd prefer this to go through my tree, let me know. Thanks for the review. I'll respin and use error_setg_errno as suggested by Eric, if it's okay. Fam