From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIMoa-0007Cc-Bt for qemu-devel@nongnu.org; Thu, 01 Nov 2018 19:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIMoX-0005Ej-B3 for qemu-devel@nongnu.org; Thu, 01 Nov 2018 19:55:52 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:41778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gIMoX-0005E4-2R for qemu-devel@nongnu.org; Thu, 01 Nov 2018 19:55:49 -0400 Received: by mail-pg1-x535.google.com with SMTP id k13so105539pga.8 for ; Thu, 01 Nov 2018 16:55:48 -0700 (PDT) Date: Thu, 1 Nov 2018 16:55:23 -0700 Message-Id: <20181101235525.29042-2-palmer@sifive.com> In-Reply-To: <20181101235525.29042-1-palmer@sifive.com> References: <20181101235525.29042-1-palmer@sifive.com> From: Palmer Dabbelt Subject: [Qemu-devel] [PULL 1/3] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Dayeol Lee , Palmer Dabbelt From: Dayeol Lee pmp_read_cfg() returns 8-bit value, which is combined together to form a single pmpcfg CSR. The default promotion rules will result in an integer here ("i*8" is integer, which flows through) resulting in a 32-bit signed value on most hosts. That's bogus on RV64I, with the high bits of the CSR being wrong. Signed-off-by: Dayeol Lee Reviewed-by: Palmer Dabbelt Reviewed-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- target/riscv/pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index f432f3b7594b..03abd8fe5eb7 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -325,7 +325,7 @@ target_ulong pmpcfg_csr_read(CPURISCVState *env, uint32_t reg_index) { int i; target_ulong cfg_val = 0; - uint8_t val = 0; + target_ulong val = 0; for (i = 0; i < sizeof(target_ulong); i++) { val = pmp_read_cfg(env, (reg_index * sizeof(target_ulong)) + i); -- 2.18.1