From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>,
Leonid Bloch <lbloch@janustech.com>,
Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions
Date: Fri, 2 Nov 2018 12:07:34 +0100 [thread overview]
Message-ID: <20181102110734.GE7521@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <20181102085800.21860-1-philmd@redhat.com>
Am 02.11.2018 um 09:58 hat Philippe Mathieu-Daudé geschrieben:
> This definitions are QCow2 specific, there is no need to expose them
> in the global namespace.
>
> This partially reverts commit 540b8492618eb.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
If we don't want this globally, I think we also don't want it in qcow2.
Or at least reduce it to only those constants that qcow2 actually uses.
Kevin
next prev parent reply other threads:[~2018-11-02 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 8:58 [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions Philippe Mathieu-Daudé
2018-11-02 11:07 ` Kevin Wolf [this message]
2018-11-02 12:37 ` Philippe Mathieu-Daudé
2018-11-02 14:10 ` Kevin Wolf
2018-11-02 14:52 ` Eric Blake
2018-11-02 15:28 ` Kevin Wolf
2018-11-03 0:29 ` Leonid Bloch
2018-11-05 15:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102110734.GE7521@dhcp-200-186.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=lbloch@janustech.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).