[Qemu-devel] [PULL 0/1] softfloat: Don't execute divdeu without power7

[Qemu-devel] [PULL 0/1] softfloat: Don't execute divdeu without power7

[Richard Henderson]

The following changes since commit 7d56239f159afc2e7bd42623947e56ba48f37836:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181102' into staging (2018-11-02 17:17:12 +0000)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-softfloat-20181104

for you to fetch changes up to 7370981bd1ef58b3c20ba8b83cc342d1c61bc773:

  softfloat: Don't execute divdeu without power7 (2018-11-04 10:04:40 +0000)

----------------------------------------------------------------
Only use divdeu insn with Power7 and later.

----------------------------------------------------------------
Richard Henderson (1):
      softfloat: Don't execute divdeu without power7

 include/fpu/softfloat-macros.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL 1/1] softfloat: Don't execute divdeu without power7

[Richard Henderson]

The divdeu instruction was added to ISA 2.06 (Power7).
Exclude this block from older cpus.

Fixes: 27ae5109a2ba (softfloat: Specialize udiv_qrnnd for ppc64)
Reported-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/fpu/softfloat-macros.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h
index c86687fa5e..b1d772e6d4 100644
--- a/include/fpu/softfloat-macros.h
+++ b/include/fpu/softfloat-macros.h
@@ -647,8 +647,8 @@ static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t n1,
     asm("dlgr %0, %1" : "+r"(n) : "r"(d));
     *r = n >> 64;
     return n;
-#elif defined(_ARCH_PPC64)
-    /* From Power ISA 3.0B, programming note for divdeu.  */
+#elif defined(_ARCH_PPC64) && defined(_ARCH_PWR7)
+    /* From Power ISA 2.06, programming note for divdeu.  */
     uint64_t q1, q2, Q, r1, r2, R;
     asm("divdeu %0,%2,%4; divdu %1,%3,%4"
         : "=&r"(q1), "=r"(q2)
-- 
2.17.2

Re: [Qemu-devel] [PULL 0/1] softfloat: Don't execute divdeu without power7

[Peter Maydell]

On 4 November 2018 at 10:08, Richard Henderson
<richard.henderson@linaro.org> wrote:
> The following changes since commit 7d56239f159afc2e7bd42623947e56ba48f37836:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181102' into staging (2018-11-02 17:17:12 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-softfloat-20181104
>
> for you to fetch changes up to 7370981bd1ef58b3c20ba8b83cc342d1c61bc773:
>
>   softfloat: Don't execute divdeu without power7 (2018-11-04 10:04:40 +0000)
>
> ----------------------------------------------------------------
> Only use divdeu insn with Power7 and later.
>
> ----------------------------------------------------------------
> Richard Henderson (1):
>       softfloat: Don't execute divdeu without power7



Applied, thanks.

-- PMM