qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, cohuck@redhat.com,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Fam Zheng" <famz@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Jeff Cody" <jcody@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Daniel Berrange" <berrange@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v3 1/8] README: use 'https://' instead of 'git://'
Date: Sun,  4 Nov 2018 11:24:17 +0000	[thread overview]
Message-ID: <20181104112424.18663-2-stefanha@redhat.com> (raw)
In-Reply-To: <20181104112424.18663-1-stefanha@redhat.com>

When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks.  HTTPS is more secure
since the client verifies the server certificate.

Reported-by: Jann Horn <jannh@google.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 README         | 4 ++--
 pc-bios/README | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/README b/README
index 49a9fd09cd..441c33eb2f 100644
--- a/README
+++ b/README
@@ -54,7 +54,7 @@ Submitting patches
 
 The QEMU source code is maintained under the GIT version control system.
 
-   git clone git://git.qemu.org/qemu.git
+   git clone https://git.qemu.org/git/qemu.git
 
 When submitting patches, one common approach is to use 'git
 format-patch' and/or 'git send-email' to format & send the mail to the
@@ -70,7 +70,7 @@ the QEMU website
 
 The QEMU website is also maintained under source control.
 
-  git clone git://git.qemu.org/qemu-web.git
+  git clone https://git.qemu.org/git/qemu-web.git
   https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/
 
 A 'git-publish' utility was created to make above process less
diff --git a/pc-bios/README b/pc-bios/README
index 90f0fa7aa7..b572e9eb00 100644
--- a/pc-bios/README
+++ b/pc-bios/README
@@ -23,7 +23,7 @@
   legacy x86 software to communicate with an attached serial console as
   if a video card were attached.  The master sources reside in a subversion
   repository at http://sgabios.googlecode.com/svn/trunk.  A git mirror is
-  available at git://git.qemu.org/sgabios.git.
+  available at https://git.qemu.org/git/sgabios.git.
 
 - The PXE roms come from the iPXE project. Built with BANNER_TIME 0.
   Sources available at http://ipxe.org.  Vendor:Device ID -> ROM mapping:
@@ -40,7 +40,7 @@
 
 - The u-boot binary for e500 comes from the upstream denx u-boot project where
   it was compiled using the qemu-ppce500 target.
-  A git mirror is available at: git://git.qemu.org/u-boot.git
+  A git mirror is available at: https://git.qemu.org/git/u-boot.git
   The hash used to compile the current version is: 2072e72
 
 - Skiboot (https://github.com/open-power/skiboot/) is an OPAL
-- 
2.17.2

  reply	other threads:[~2018-11-04 11:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-04 11:24 [Qemu-devel] [PATCH v3 0/8] Use 'https://' instead of 'git://' Stefan Hajnoczi
2018-11-04 11:24 ` Stefan Hajnoczi [this message]
2018-11-04 22:38   ` [Qemu-devel] [PATCH v3 1/8] README: use " Philippe Mathieu-Daudé
2018-11-05 11:51   ` Alex Bennée
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 2/8] get_maintainer: " Stefan Hajnoczi
2018-11-04 22:37   ` Philippe Mathieu-Daudé
2018-11-08 10:55     ` Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 3/8] MAINTAINERS: use 'https://' instead of 'git://' for GitHub Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 4/8] gitmodules: use 'https://' instead of 'git://' Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 5/8] git: use HTTPS git URLs for repo.or.cz Stefan Hajnoczi
2018-11-05 15:54   ` Eric Blake
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 6/8] pc-testdev: use HTTPS git URL Stefan Hajnoczi
2018-11-04 22:33   ` Philippe Mathieu-Daudé
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 7/8] target-alpha: use HTTPS git URL for palcode Stefan Hajnoczi
2018-11-04 22:34   ` Philippe Mathieu-Daudé
2018-11-05  7:08   ` Richard Henderson
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 8/8] docker: use HTTPS git URL for virglrenderer Stefan Hajnoczi
2018-11-04 22:35   ` Philippe Mathieu-Daudé
2018-11-05 12:03   ` Alex Bennée
2018-11-04 22:23 ` [Qemu-devel] [PATCH v3 0/8] Use 'https://' instead of 'git://' Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181104112424.18663-2-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eblake@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).