From: Yuval Shaia <yuval.shaia@oracle.com>
To: yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com,
dmitry.fleytman@gmail.com, jasowang@redhat.com,
eblake@redhat.com, armbru@redhat.com,
shamir.rabinovitch@oracle.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 06/18] hw/pvrdma: Make function reset_device return void
Date: Mon, 5 Nov 2018 14:45:47 +0200 [thread overview]
Message-ID: <20181105124559.21561-7-yuval.shaia@oracle.com> (raw)
In-Reply-To: <20181105124559.21561-1-yuval.shaia@oracle.com>
This function cannot fail - fix it to return void
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
hw/rdma/vmw/pvrdma_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 6c8c0154fa..fc2abd34af 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -369,13 +369,11 @@ static int unquiesce_device(PVRDMADev *dev)
return 0;
}
-static int reset_device(PVRDMADev *dev)
+static void reset_device(PVRDMADev *dev)
{
pvrdma_stop(dev);
pr_dbg("Device reset complete\n");
-
- return 0;
}
static uint64_t regs_read(void *opaque, hwaddr addr, unsigned size)
--
2.17.2
next prev parent reply other threads:[~2018-11-05 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 12:45 [Qemu-devel] [PATCH 00/18] Add support for RDMA MAD Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 01/18] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 02/18] hw/rdma: Add ability to force notification without re-arm Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 03/18] hw/rdma: Return qpn 1 if ibqp is NULL Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 04/18] hw/rdma: Abort send-op if fail to create addr handler Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 05/18] hw/rdma: Add support for MAD packets Yuval Shaia
2018-11-05 12:45 ` Yuval Shaia [this message]
2018-11-05 12:45 ` [Qemu-devel] [PATCH 07/18] hw/pvrdma: Make default pkey 0xFFFF Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 08/18] hw/pvrdma: Set the correct opcode for recv completion Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 09/18] hw/pvrdma: Set the correct opcode for send completion Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 10/18] json: Define new QMP message for pvrdma Yuval Shaia
2018-11-05 15:58 ` Eric Blake
2018-11-06 9:49 ` Yuval Shaia
2018-11-07 8:11 ` Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 11/18] hw/pvrdma: Add support to allow guest to configure GID table Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 12/18] vmxnet3: Move some definitions to header file Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 13/18] hw/pvrdma: Make sure PCI function 0 is vmxnet3 Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 14/18] hw/rdma: Initialize node_guid from vmxnet3 mac address Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 15/18] hw/pvrdma: Make device state depend on Ethernet function state Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 16/18] hw/pvrdma: Fill all CQE fields Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 17/18] hw/pvrdma: Fill error code in command's response Yuval Shaia
2018-11-05 12:45 ` [Qemu-devel] [PATCH 18/18] hw/rdma: Remove unneeded code that handles more that one port Yuval Shaia
2018-11-05 17:20 ` [Qemu-devel] [PATCH 00/18] Add support for RDMA MAD no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105124559.21561-7-yuval.shaia@oracle.com \
--to=yuval.shaia@oracle.com \
--cc=armbru@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=shamir.rabinovitch@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).