qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alexander Graf" <agraf@suse.de>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Eric Blake" <eblake@redhat.com>,
	qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
	"Andreas Färber" <afaerber@suse.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH v2 6/6] add UsageHints to QemuSupportState
Date: Tue,  6 Nov 2018 11:23:35 +0100	[thread overview]
Message-ID: <20181106102335.20027-7-kraxel@redhat.com> (raw)
In-Reply-To: <20181106102335.20027-1-kraxel@redhat.com>

So we can add device usage recommendations to devices,
independant from support state.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/qemu/support-state.h |  1 +
 qapi/common.json             | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/include/qemu/support-state.h b/include/qemu/support-state.h
index 6567d8702b..6ea0d03bd5 100644
--- a/include/qemu/support-state.h
+++ b/include/qemu/support-state.h
@@ -5,6 +5,7 @@
 
 typedef struct QemuSupportState {
     SupportState state;
+    UsageHints   hints;
     const char   *help;
 } QemuSupportState;
 
diff --git a/qapi/common.json b/qapi/common.json
index 00374127b8..6952ea2074 100644
--- a/qapi/common.json
+++ b/qapi/common.json
@@ -183,3 +183,32 @@
             'unsupported',
             'obsolete',
             'deprecated' ] }
+
+##
+# @UsageHints:
+#
+# Usage recommendations.
+#
+# @unspecified: not specified (zero-initialized).
+#
+# @green: Best choice.  Typically paravirtual devices go into this
+#         category.
+#         Example (nic): virtio-net.
+#         Example (usb); xhci.
+#
+# @yellow: Reasonable choice.  Typically emulated devices with
+#          good performance go into this category.
+#          Example (nic): e1000, e1000e
+#
+# @red: Bad choice.  Avoid this unless you run an old guest which
+#       lacks support for something better.
+#       Example (nic): rtl8139, pcnet, ne2k, ...
+#       Example (usb): ehci, uhci, ohci
+#
+# Since: 3.2
+##
+{ 'enum': 'UsageHints',
+  'data': [ 'unspecified',
+            'green',
+            'yellow',
+            'red' ] }
-- 
2.9.3

  parent reply	other threads:[~2018-11-06 10:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 10:23 [Qemu-devel] [PATCH v2 0/6] Introducing QemuSupportState Gerd Hoffmann
2018-11-06 10:23 ` [Qemu-devel] [PATCH v2 1/6] move ObjectClass to typedefs.h Gerd Hoffmann
2018-11-06 22:45   ` David Gibson
2018-11-07  9:53   ` Philippe Mathieu-Daudé
2018-11-06 10:23 ` [Qemu-devel] [PATCH v2 2/6] add QemuSupportState Gerd Hoffmann
2018-11-06 14:26   ` Eduardo Habkost
2018-11-06 23:12     ` Paolo Bonzini
2018-11-07  8:15       ` Gerd Hoffmann
2018-11-06 10:23 ` [Qemu-devel] [PATCH v2 3/6] Use QemuSupportState for machine types Gerd Hoffmann
2018-11-29 17:48   ` Markus Armbruster
2018-11-06 10:23 ` [Qemu-devel] [PATCH v2 4/6] Warn on obsolete and deprecated devices Gerd Hoffmann
2018-11-06 14:36   ` Michael S. Tsirkin
2018-11-07  8:06     ` Gerd Hoffmann
2018-11-29 17:56   ` Markus Armbruster
2018-11-06 10:23 ` [Qemu-devel] [PATCH v2 5/6] tag cirrus as obsolete Gerd Hoffmann
2018-11-06 10:23 ` Gerd Hoffmann [this message]
2018-11-29 19:10   ` [Qemu-devel] [PATCH v2 6/6] add UsageHints to QemuSupportState Markus Armbruster
2018-11-29 19:14 ` [Qemu-devel] [PATCH v2 0/6] Introducing QemuSupportState Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181106102335.20027-7-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).