From: Kevin Wolf <kwolf@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: armbru@redhat.com, mreitz@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] blockdev: handle error on block latency histogram set error
Date: Tue, 6 Nov 2018 17:52:00 +0100 [thread overview]
Message-ID: <20181106165200.GD4758@linux.fritz.box> (raw)
In-Reply-To: <1541387096-19513-1-git-send-email-pizhenwei@bytedance.com>
Am 05.11.2018 um 04:04 hat zhenwei pi geschrieben:
> Function block_latency_histogram_set may return error, but qapi ignore this.
> This can be reproduced easily by qmp command:
> virsh qemu-monitor-command INSTANCE '{"execute":"x-block-latency-histogram-set",
> "arguments":{"device":"drive-virtio-disk1","boundaries":[10,200,40]}}'
> In fact this command does not work, but we still get success result.
>
> qmp_x_block_latency_histogram_set is a batch setting API, report error ASAP.
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2018-11-06 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:04 [Qemu-devel] [PATCH] blockdev: handle error on block latency histogram set error zhenwei pi
2018-11-06 16:52 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106165200.GD4758@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).