From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKJWz-00071A-Uc for qemu-devel@nongnu.org; Wed, 07 Nov 2018 03:49:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKJWw-0000Jd-L0 for qemu-devel@nongnu.org; Wed, 07 Nov 2018 03:49:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47096) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKJWv-0008VT-Vt for qemu-devel@nongnu.org; Wed, 07 Nov 2018 03:49:42 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EEADF58E45 for ; Wed, 7 Nov 2018 08:49:35 +0000 (UTC) Date: Wed, 7 Nov 2018 09:49:31 +0100 From: Kashyap Chamarthy Message-ID: <20181107084931.GB19617@paraplu> References: <20181030123526.26415-1-kchamart@redhat.com> <20181030123526.26415-3-kchamart@redhat.com> <10e3b401-92fc-f096-9e7e-b08223408ce9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10e3b401-92fc-f096-9e7e-b08223408ce9@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/3] Deprecate HMP `cpu-add` List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, eblake@redhat.com, armbru@redhat.com, ehabkost@redhat.com, imammedo@redhat.com On Mon, Nov 05, 2018 at 12:20:05PM +0100, Thomas Huth wrote: > On 2018-10-30 13:35, Kashyap Chamarthy wrote: > > Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP > > equivalent, too. > > > > Suggested-by: Thomas Huth > > Signed-off-by: Kashyap Chamarthy [...] > > diff --git a/hmp.c b/hmp.c > > index 4975fa56b0..c3f3db7795 100644 > > --- a/hmp.c > > +++ b/hmp.c > > @@ -2353,6 +2353,8 @@ void hmp_cpu_add(Monitor *mon, const QDict *qdict) > > int cpuid; > > Error *err = NULL; > > > > + error_report("cpu_add is deprecated, please use device_add instead"); > > + > > cpuid = qdict_get_int(qdict, "id"); > > qmp_cpu_add(cpuid, &err); > > hmp_handle_error(mon, &err); > > > > I think you should also mention this explicitly in qemu-deprecated.texi, > too. I think you mean I should explicitly mention that the HMP equivalent is also deprecated -- currently I only call out the QMP command: 'qemu-deprecated.texi'. I saw that Eduardo already queued this series; maybe I can add a follow-up if it can't be tweaked before submitting a pull request. Thanks for the review! -- /kashyap