From: "Richard W.M. Jones" <rjones@redhat.com>
To: Nir Soffer <nsoffer@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Eric Blake <eblake@redhat.com>,
qemu-block <qemu-block@nongnu.org>,
edgar.kaziakhmedov@virtuozzo.com
Subject: Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data
Date: Wed, 7 Nov 2018 15:02:19 +0000 [thread overview]
Message-ID: <20181107150219.GC27120@redhat.com> (raw)
In-Reply-To: <CAMRbyyuFGVtNWF9LKoi0n6_r5Gr4j8LetbAMd0L_5cKMif9LjQ@mail.gmail.com>
On Wed, Nov 07, 2018 at 04:56:48PM +0200, Nir Soffer wrote:
> Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones <rjones@redhat.com> wrote:
>
> > Another thing I tried was to change the NBD server (nbdkit) so that it
> > doesn't advertise zero support to the client:
> >
> > $ nbdkit --filter=log --filter=nozero memory size=6G logfile=/tmp/log \
> > --run './qemu-img convert ./fedora-28.img -n $nbd'
> > $ grep '\.\.\.$' /tmp/log | sed 's/.*\([A-Z][a-z]*\).*/\1/' | uniq -c
> > 2154 Write
> >
> > Not surprisingly no zero commands are issued. The size of the write
> > commands is very uneven -- it appears to be send one command per block
> > of zeroes or data.
> >
> > Nir: If we could get information from imageio about whether zeroing is
> > implemented efficiently or not by the backend, we could change
> > virt-v2v / nbdkit to advertise this back to qemu.
> >
>
> There is no way to detect the capability, ioctl(BLKZEROOUT) always
> succeeds, falling back to manual zeroing in the kernel silently
>
> Even if we could, sending zero on the wire from qemu may be even
> slower,
Yes this is a very good point. Sending zeroes would be terrible.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/
next prev parent reply other threads:[~2018-11-07 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 12:13 [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data Richard W.M. Jones
2018-11-07 14:36 ` Richard W.M. Jones
2018-11-07 14:56 ` Nir Soffer
2018-11-07 15:02 ` Richard W.M. Jones [this message]
2018-11-07 17:27 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2018-11-07 17:55 ` Nir Soffer
2018-11-11 16:11 ` Nir Soffer
2018-11-15 22:27 ` Nir Soffer
2018-11-16 15:26 ` Kevin Wolf
2018-11-17 20:59 ` Nir Soffer
2018-11-17 21:13 ` Richard W.M. Jones
2018-11-18 7:24 ` Nir Soffer
2018-11-19 11:50 ` Kevin Wolf
2018-11-07 16:42 ` [Qemu-devel] " Eric Blake
2018-11-11 15:25 ` Nir Soffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107150219.GC27120@redhat.com \
--to=rjones@redhat.com \
--cc=eblake@redhat.com \
--cc=edgar.kaziakhmedov@virtuozzo.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).