From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel Berrange" <berrange@redhat.com>,
eblake@redhat.com, "Peter Maydell" <peter.maydell@linaro.org>,
"Jeff Cody" <jcody@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
cohuck@redhat.com, "Paolo Bonzini" <pbonzini@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 6/8] pc-testdev: use HTTPS git URL
Date: Thu, 8 Nov 2018 11:15:29 +0000 [thread overview]
Message-ID: <20181108111531.30671-7-stefanha@redhat.com> (raw)
In-Reply-To: <20181108111531.30671-1-stefanha@redhat.com>
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks. HTTPS is more secure
since the client verifies the server certificate.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Suggested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/misc/pc-testdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/pc-testdev.c b/hw/misc/pc-testdev.c
index 697eb88c97..0aee04f231 100644
--- a/hw/misc/pc-testdev.c
+++ b/hw/misc/pc-testdev.c
@@ -32,7 +32,7 @@
* -kernel /home/lmr/Code/virt-test.git/kvm/unittests/msr.flat
*
* Where msr.flat is one of the KVM unittests, present on a separate repo,
- * git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
+ * https://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
*/
#include "qemu/osdep.h"
--
2.19.1
next prev parent reply other threads:[~2018-11-08 11:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 11:15 [Qemu-devel] [PATCH v4 0/8] Use 'https://' instead of 'git://' Stefan Hajnoczi
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 1/8] README: use " Stefan Hajnoczi
2018-11-08 11:52 ` Cornelia Huck
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 2/8] get_maintainer: " Stefan Hajnoczi
2018-11-08 11:53 ` Cornelia Huck
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 3/8] MAINTAINERS: use 'https://' instead of 'git://' for GitHub Stefan Hajnoczi
2018-11-08 11:56 ` Cornelia Huck
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 4/8] gitmodules: use 'https://' instead of 'git://' Stefan Hajnoczi
2018-11-08 11:58 ` Cornelia Huck
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 5/8] git: use HTTPS git URLs for repo.or.cz Stefan Hajnoczi
2018-11-08 11:59 ` Cornelia Huck
2018-11-08 11:15 ` Stefan Hajnoczi [this message]
2018-11-08 12:01 ` [Qemu-devel] [PATCH v4 6/8] pc-testdev: use HTTPS git URL Cornelia Huck
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 7/8] target-alpha: use HTTPS git URL for palcode Stefan Hajnoczi
2018-11-08 12:02 ` Cornelia Huck
2018-11-08 11:15 ` [Qemu-devel] [PATCH v4 8/8] docker: use HTTPS git URL for virglrenderer Stefan Hajnoczi
2018-11-08 12:04 ` Cornelia Huck
2018-11-09 18:16 ` [Qemu-devel] [PATCH v4 0/8] Use 'https://' instead of 'git://' Michael S. Tsirkin
2018-11-12 13:48 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108111531.30671-7-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).