From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKiJg-0006DB-IJ for qemu-devel@nongnu.org; Thu, 08 Nov 2018 06:17:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKiJc-0000h0-Hu for qemu-devel@nongnu.org; Thu, 08 Nov 2018 06:17:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35844) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKiJc-0008RE-7U for qemu-devel@nongnu.org; Thu, 08 Nov 2018 06:17:36 -0500 From: Stefan Hajnoczi Date: Thu, 8 Nov 2018 11:15:29 +0000 Message-Id: <20181108111531.30671-7-stefanha@redhat.com> In-Reply-To: <20181108111531.30671-1-stefanha@redhat.com> References: <20181108111531.30671-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v4 6/8] pc-testdev: use HTTPS git URL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Daniel Berrange , eblake@redhat.com, Peter Maydell , Jeff Cody , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Markus Armbruster , cohuck@redhat.com, Paolo Bonzini , Fam Zheng , Stefan Hajnoczi When you clone the repository without previous commit history, 'git://' doesn't protect from man-in-the-middle attacks. HTTPS is more secure since the client verifies the server certificate. Cc: Paolo Bonzini Suggested-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Stefan Hajnoczi --- hw/misc/pc-testdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/pc-testdev.c b/hw/misc/pc-testdev.c index 697eb88c97..0aee04f231 100644 --- a/hw/misc/pc-testdev.c +++ b/hw/misc/pc-testdev.c @@ -32,7 +32,7 @@ * -kernel /home/lmr/Code/virt-test.git/kvm/unittests/msr.flat * * Where msr.flat is one of the KVM unittests, present on a separate rep= o, - * git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git + * https://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git */ =20 #include "qemu/osdep.h" --=20 2.19.1