From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKiH6-0004ET-Jy for qemu-devel@nongnu.org; Thu, 08 Nov 2018 06:15:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKiH2-0000sR-Kj for qemu-devel@nongnu.org; Thu, 08 Nov 2018 06:15:00 -0500 Date: Thu, 8 Nov 2018 12:14:46 +0100 From: Cornelia Huck Message-ID: <20181108121446.4f1d09dc.cohuck@redhat.com> In-Reply-To: References: <20181105110313.29312-1-david@redhat.com> <20181105110313.29312-5-david@redhat.com> <20181105134118.01fef179.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Thomas Huth , qemu-devel@nongnu.org, "Michael S . Tsirkin" , Igor Mammedov , Alexander Graf , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson , =Collin Walling On Mon, 5 Nov 2018 13:46:10 +0100 David Hildenbrand wrote: > On 05.11.18 13:41, Cornelia Huck wrote: > > On Mon, 5 Nov 2018 13:04:04 +0100 > > Thomas Huth wrote: > > > >> On 2018-11-05 12:03, David Hildenbrand wrote: > >>> Right now, errors during realize()/pre_plug/plug of the zPCI device > >>> would result in QEMU crashing instead of failing nicely when creating > >>> a zPCI device for a PCI device. > > > > Yeah, failing instead of crashing is better :) > > > > Is there any way we can trigger this problem for testing? > > I guess trying to add more PCI devices (with implicit zPCI devices > getting created) than we have zPCI slots should be enough. So making > e.g. s390_pci_alloc_idx() fail. > > (FH_MASK_INDEX = 0x0000ffff implies 65536 devices, which is not really > easy to test ;) ) > I was hoping for an easy test. Oh well :)