qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org,
	agraf@suse.de, lvivier@redhat.com,
	"Cédric Le Goater" <clg@kaod.org>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 02/22] ppc440_pcix: convert SysBus init method to a realize method
Date: Thu,  8 Nov 2018 23:16:26 +1100	[thread overview]
Message-ID: <20181108121646.26173-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20181108121646.26173-1-david@gibson.dropbear.id.au>

From: Cédric Le Goater <clg@kaod.org>

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/ppc440_pcix.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c
index 64ed07afa6..42ef76b6f5 100644
--- a/hw/ppc/ppc440_pcix.c
+++ b/hw/ppc/ppc440_pcix.c
@@ -466,17 +466,18 @@ const MemoryRegionOps ppc440_pcix_host_data_ops = {
     .endianness = DEVICE_LITTLE_ENDIAN,
 };
 
-static int ppc440_pcix_initfn(SysBusDevice *dev)
+static void ppc440_pcix_realize(DeviceState *dev, Error **errp)
 {
+    SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
     PPC440PCIXState *s;
     PCIHostState *h;
 
     h = PCI_HOST_BRIDGE(dev);
     s = PPC440_PCIX_HOST_BRIDGE(dev);
 
-    sysbus_init_irq(dev, &s->irq);
+    sysbus_init_irq(sbd, &s->irq);
     memory_region_init(&s->busmem, OBJECT(dev), "pci bus memory", UINT64_MAX);
-    h->bus = pci_register_root_bus(DEVICE(dev), NULL, ppc440_pcix_set_irq,
+    h->bus = pci_register_root_bus(dev, NULL, ppc440_pcix_set_irq,
                          ppc440_pcix_map_irq, &s->irq, &s->busmem,
                          get_system_io(), PCI_DEVFN(0, 0), 1, TYPE_PCI_BUS);
 
@@ -497,17 +498,14 @@ static int ppc440_pcix_initfn(SysBusDevice *dev)
     memory_region_add_subregion(&s->container, PCIC0_CFGADDR, &h->conf_mem);
     memory_region_add_subregion(&s->container, PCIC0_CFGDATA, &h->data_mem);
     memory_region_add_subregion(&s->container, PPC440_REG_BASE, &s->iomem);
-    sysbus_init_mmio(dev, &s->container);
-
-    return 0;
+    sysbus_init_mmio(sbd, &s->container);
 }
 
 static void ppc440_pcix_class_init(ObjectClass *klass, void *data)
 {
-    SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
     DeviceClass *dc = DEVICE_CLASS(klass);
 
-    k->init = ppc440_pcix_initfn;
+    dc->realize = ppc440_pcix_realize;
     dc->reset = ppc440_pcix_reset;
 }
 
-- 
2.19.1

  parent reply	other threads:[~2018-11-08 12:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 12:16 [Qemu-devel] [PULL 00/22] ppc-for-3.1 queue 20181108 David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 01/22] target/ppc: add external PID support David Gibson
2018-11-15 10:22   ` Peter Maydell
2018-11-19 16:39     ` Peter Maydell
2018-11-25  8:22       ` David Gibson
2018-11-08 12:16 ` David Gibson [this message]
2018-11-08 12:16 ` [Qemu-devel] [PULL 03/22] ppc4xx_pci: convert SysBus init method to a realize method David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 04/22] PPC: e500: " David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 05/22] hw/ppc/spapr_rng: Introduce CONFIG_SPAPR_RNG switch for spapr_rng.c David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 06/22] target/ppc: Split up float_invalid_op_excp David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 07/22] target/ppc: Remove float_check_status David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 08/22] target/ppc: Introduce fp number classification David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 09/22] target/ppc: Split out float_invalid_op_addsub David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 10/22] target/ppc: Split out float_invalid_op_mul David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 11/22] target/ppc: Split out float_invalid_op_div David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 12/22] target/ppc: Split out float_invalid_cvt David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 13/22] spapr_pci: convert g_malloc() to g_new() David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 14/22] macio/pmu: Fix missing vmsd terminator David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 15/22] hw/ppc/mac_newworld: Free openpic_irqs array after use David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 16/22] target/ppc: fix mtmsr instruction for icount David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 17/22] ppc/pnv: check size before data buffer access David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 18/22] MAINTAINERS: PPC: Remove myself David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 19/22] hw/ppc/ppc440_uc: Remove dead code in sdram_size() David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 20/22] This patch fixes processing of rfi instructions in icount mode David Gibson
2018-11-08 13:17   ` Greg Kurz
2018-11-08 12:16 ` [Qemu-devel] [PULL 21/22] target/ppc: Add one reg id for ptcr David Gibson
2018-11-08 12:16 ` [Qemu-devel] [PULL 22/22] ppc/spapr_caps: Add SPAPR_CAP_NESTED_KVM_HV David Gibson
2018-11-08 14:45 ` [Qemu-devel] [PULL 00/22] ppc-for-3.1 queue 20181108 Eric Blake
2018-11-08 15:14   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108121646.26173-3-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=clg@kaod.org \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).