From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] ipmi: Allow UUID to be set for a BMC
Date: Thu, 8 Nov 2018 08:19:42 -0600 [thread overview]
Message-ID: <20181108141944.15769-1-minyard@acm.org> (raw)
The code was using the qemu UUID for the BMC. But that's really
not a good method. In general, you don't want the GUID to change
when you migrate, and you want the GUID to be the same between
invocations of qemu (if you have a GUID).
Plus, if you have multiple BMCs, they need to have different
GUIDs or the host code cannot tell them apart. I'm not sure
anyone really uses multiple BMCs, but I do a lot of testing
with that scenario.
This change lets the user set the GUID on the command line, and
if the GUID is not set return an error for the GUID fetch command.
This maps better to how IPMI should work.
This change relies on the UUID being set to all zeros to know that
it is not set. This is not optimal, perhaps, but an all zero
UUID isn't valid (it's the Nil UUID), so it should be ok.
next reply other threads:[~2018-11-08 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 14:19 minyard [this message]
2018-11-08 14:19 ` [Qemu-devel] [PATCH 1/2] qdev: Add a no default uuid property minyard
2018-11-08 14:19 ` [Qemu-devel] [PATCH 2/2] ipmi: Add a UUID device property minyard
2018-11-08 23:22 ` [Qemu-devel] [PATCH 0/2] ipmi: Allow UUID to be set for a BMC David Gibson
2018-11-09 13:33 ` Corey Minyard
2018-12-06 21:10 ` Paolo Bonzini
2018-12-06 21:27 ` Corey Minyard
2018-12-06 21:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108141944.15769-1-minyard@acm.org \
--to=minyard@acm.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=famz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).