From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKlhL-0000rI-Do for qemu-devel@nongnu.org; Thu, 08 Nov 2018 09:54:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKlhD-00035J-N2 for qemu-devel@nongnu.org; Thu, 08 Nov 2018 09:54:15 -0500 Date: Thu, 8 Nov 2018 15:53:48 +0100 From: Igor Mammedov Message-ID: <20181108155348.03d368db@redhat.com> In-Reply-To: <20181108151623.4de26ecb@redhat.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-6-sameo@linux.intel.com> <20181108151623.4de26ecb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Ortiz Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson On Thu, 8 Nov 2018 15:16:23 +0100 Igor Mammedov wrote: [...] > patch 4: convert arm's impl. to build_append_int_noprefix() API (commit 5d7a334f7) > ... move out to aml-build.c my mistake, generally when we move something out, we should do it in separate path preferably without any changes to the moved code so it would be easier to review. So it should be a separate patch. [...]