qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	peter.maydell@linaro.org, mst@redhat.com,
	jean-philippe.brucker@arm.com
Cc: kevin.tian@intel.com, tn@semihalf.com, bharat.bhushan@nxp.com,
	peterx@redhat.com
Subject: [Qemu-devel] [RFC v8 13/18] virtio_iommu: Handle reserved regions in translation process
Date: Fri,  9 Nov 2018 12:29:52 +0100	[thread overview]
Message-ID: <20181109112957.10067-14-eric.auger@redhat.com> (raw)
In-Reply-To: <20181109112957.10067-1-eric.auger@redhat.com>

When translating an address we need to check if it belongs to
a reserved virtual address range. If it does, there are 2 cases:

- it belongs to a RESERVED region: the guest should neither use
  this address in a MAP not instruct the end-point to DMA on
  them. We report an error

- It belongs to an MSI region: we bypass the translation.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 hw/virtio/virtio-iommu.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index e5ab3db834..c88aecf18f 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -743,6 +743,7 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr,
     viommu_interval interval;
     bool bypass_allowed;
     bool read_fault, write_fault;
+    struct virtio_iommu_probe_resv_mem *reg;
 
     interval.low = addr;
     interval.high = addr + 1;
@@ -775,6 +776,21 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr,
         goto unlock;
     }
 
+    reg = g_tree_lookup(ep->reserved_regions, (gpointer)(&interval));
+    if (reg) {
+        switch (reg->subtype) {
+        case VIRTIO_IOMMU_RESV_MEM_T_MSI:
+            entry.perm = flag;
+            break;
+        case VIRTIO_IOMMU_RESV_MEM_T_RESERVED:
+        default:
+            virtio_iommu_report_fault(s, VIRTIO_IOMMU_FAULT_R_MAPPING,
+                                      0, sid, addr);
+            break;
+        }
+        goto unlock;
+    }
+
     if (!ep->domain) {
         if (!bypass_allowed) {
             qemu_log_mask(LOG_GUEST_ERROR,
-- 
2.17.2

  parent reply	other threads:[~2018-11-09 11:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 11:29 [Qemu-devel] [RFC v8 00/18] VIRTIO-IOMMU device Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 01/18] update-linux-headers: Import virtio_iommu.h Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 02/18] linux-headers: Partial update for virtio-iommu v0.8 Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 03/18] virtio-iommu: Add skeleton Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 04/18] virtio-iommu: Decode the command payload Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 05/18] virtio-iommu: Add the iommu regions Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 06/18] virtio-iommu: Endpoint and domains structs and helpers Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 07/18] virtio-iommu: Implement attach/detach command Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 08/18] virtio-iommu: Implement map/unmap Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 09/18] virtio-iommu: Implement translate Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 10/18] virtio-iommu: Implement probe request Eric Auger
2018-11-14 16:01   ` Jean-Philippe Brucker
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property Eric Auger
2018-11-14 16:01   ` Jean-Philippe Brucker
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 12/18] virtio-iommu: Implement fault reporting Eric Auger
2018-11-09 11:29 ` Eric Auger [this message]
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 14/18] virtio-iommu-pci: Add virtio iommu pci support Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board Eric Auger
2018-11-14 16:01   ` Jean-Philippe Brucker
2018-11-14 16:41     ` Auger Eric
2018-11-16  9:51       ` Auger Eric
2018-11-22  9:15   ` Bharat Bhushan
2018-11-22  9:25     ` Auger Eric
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 16/18] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 17/18] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table Eric Auger
2018-11-09 11:29 ` [Qemu-devel] [RFC v8 18/18] hw/arm/virt: Allow virtio-iommu instantiation Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109112957.10067-14-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=bharat.bhushan@nxp.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=jean-philippe.brucker@arm.com \
    --cc=kevin.tian@intel.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tn@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).