* [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file
@ 2018-11-09 16:13 Michael Roth
2018-11-11 23:39 ` Philippe Mathieu-Daudé
2018-11-14 16:55 ` Michael Roth
0 siblings, 2 replies; 4+ messages in thread
From: Michael Roth @ 2018-11-09 16:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-stable
This is needed to build skiboot from tarball-distributed sources
since the git data the make_release.sh script relies on to generate
it is not available.
Cc: qemu-stable@nongnu.org
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
scripts/make-release | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/make-release b/scripts/make-release
index 04fa9defdc..c14f75b12c 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -19,6 +19,7 @@ pushd ${destination}
git checkout "v${version}"
git submodule update --init
(cd roms/seabios && git describe --tags --long --dirty > .version)
+(cd roms/skiboot && ./make_version.sh > .version)
# FIXME: The following line is a workaround for avoiding filename collisions
# when unpacking u-boot sources on case-insensitive filesystems. Once we
# update to something with u-boot commit 610eec7f0 we can drop this line.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file
2018-11-09 16:13 [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file Michael Roth
@ 2018-11-11 23:39 ` Philippe Mathieu-Daudé
2018-11-14 16:55 ` Michael Roth
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-11 23:39 UTC (permalink / raw)
To: Michael Roth; +Cc: qemu-devel@nongnu.org Developers, qemu-stable
On Fri, Nov 9, 2018 at 5:16 PM Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
>
> This is needed to build skiboot from tarball-distributed sources
> since the git data the make_release.sh script relies on to generate
> it is not available.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> scripts/make-release | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 04fa9defdc..c14f75b12c 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,6 +19,7 @@ pushd ${destination}
> git checkout "v${version}"
> git submodule update --init
> (cd roms/seabios && git describe --tags --long --dirty > .version)
> +(cd roms/skiboot && ./make_version.sh > .version)
> # FIXME: The following line is a workaround for avoiding filename collisions
> # when unpacking u-boot sources on case-insensitive filesystems. Once we
> # update to something with u-boot commit 610eec7f0 we can drop this line.
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file
2018-11-09 16:13 [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file Michael Roth
2018-11-11 23:39 ` Philippe Mathieu-Daudé
@ 2018-11-14 16:55 ` Michael Roth
2018-11-15 13:36 ` Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Michael Roth @ 2018-11-14 16:55 UTC (permalink / raw)
To: qemu-devel, peter.maydell; +Cc: qemu-stable
Quoting Michael Roth (2018-11-09 10:13:52)
> This is needed to build skiboot from tarball-distributed sources
> since the git data the make_release.sh script relies on to generate
> it is not available.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Hi Peter,
Should I go ahead and send this as a standalone pull or should it go in
through someone else?
> ---
> scripts/make-release | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 04fa9defdc..c14f75b12c 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -19,6 +19,7 @@ pushd ${destination}
> git checkout "v${version}"
> git submodule update --init
> (cd roms/seabios && git describe --tags --long --dirty > .version)
> +(cd roms/skiboot && ./make_version.sh > .version)
> # FIXME: The following line is a workaround for avoiding filename collisions
> # when unpacking u-boot sources on case-insensitive filesystems. Once we
> # update to something with u-boot commit 610eec7f0 we can drop this line.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file
2018-11-14 16:55 ` Michael Roth
@ 2018-11-15 13:36 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2018-11-15 13:36 UTC (permalink / raw)
To: Michael Roth; +Cc: QEMU Developers, qemu-stable
On 14 November 2018 at 16:55, Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> Quoting Michael Roth (2018-11-09 10:13:52)
>> This is needed to build skiboot from tarball-distributed sources
>> since the git data the make_release.sh script relies on to generate
>> it is not available.
>>
>> Cc: qemu-stable@nongnu.org
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
>
> Hi Peter,
>
> Should I go ahead and send this as a standalone pull or should it go in
> through someone else?
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-15 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-09 16:13 [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file Michael Roth
2018-11-11 23:39 ` Philippe Mathieu-Daudé
2018-11-14 16:55 ` Michael Roth
2018-11-15 13:36 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).