From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLBPv-0001Ap-Jx for qemu-devel@nongnu.org; Fri, 09 Nov 2018 13:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLBPr-0000Bq-5E for qemu-devel@nongnu.org; Fri, 09 Nov 2018 13:22:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47158) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gLBPq-0000BT-Tp for qemu-devel@nongnu.org; Fri, 09 Nov 2018 13:21:59 -0500 From: Wainer dos Santos Moschetta Date: Fri, 9 Nov 2018 13:21:53 -0500 Message-Id: <20181109182153.5390-1-wainersm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: ccarrara@redhat.com, ehabkost@redhat.com, crosa@redhat.com, philmd@redhat.com, lizhijian@cn.fujitsu.com QEMU used to exits with a not accurate error message when an initrd > 2GiB was passed. That was fixed on patch: commit f3839fda5771596152b75dd1e1a6d050e6e6e380 Author: Li Zhijian Date: Thu Sep 13 18:07:13 2018 +0800 change get_image_size return type to int64_t This change adds a regression test for that fix. It starts QEMU with a 2GiB dummy initrd, and check it evaluates the file size correctly and prints accurate message. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Caio Carrara Reviewed-by: Cleber Rosa Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- Changes in v2: * disambiguous GB vs GiB in comments and commit msg [ehabkost] * uses max_size variable [crosa] * checks return code equals to 1 [ehabkost] * checks expected message contain needed max_size [crosa] --- tests/acceptance/linux_initrd.py | 48 ++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 tests/acceptance/linux_initrd.py diff --git a/tests/acceptance/linux_initrd.py b/tests/acceptance/linux_in= itrd.py new file mode 100644 index 0000000000..737355c2ef --- /dev/null +++ b/tests/acceptance/linux_initrd.py @@ -0,0 +1,48 @@ +# Linux initrd acceptance test. +# +# Copyright (c) 2018 Red Hat, Inc. +# +# Author: +# Wainer dos Santos Moschetta +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + +import tempfile +from avocado.utils.process import run + +from avocado_qemu import Test + + +class LinuxInitrd(Test): + """ + Checks QEMU evaluates correctly the initrd file passed as -initrd op= tion. + + :avocado: enable + :avocado: tags=3Dx86_64 + """ + + timeout =3D 60 + + def test_with_2gib_file_should_exit_error_msg(self): + """ + Pretends to boot QEMU with an initrd file with size of 2GiB + and expect it exits with error message. + """ + kernel_url =3D ('https://mirrors.kernel.org/fedora/releases/28/' + 'Everything/x86_64/os/images/pxeboot/vmlinuz') + kernel_hash =3D '238e083e114c48200f80d889f7e32eeb2793e02a' + kernel_path =3D self.fetch_asset(kernel_url, asset_hash=3Dkernel= _hash) + max_size =3D 2 * (1024 ** 3) - 1 + + with tempfile.NamedTemporaryFile() as initrd: + initrd.seek(max_size) + initrd.write(b'\0') + initrd.flush() + cmd =3D "%s -kernel %s -initrd %s" % (self.qemu_bin, kernel_= path, + initrd.name) + res =3D run(cmd, ignore_status=3DTrue) + self.assertEqual(res.exit_status, 1) + expected_msg =3D r'.*initrd is too large.*max: \d+, need %s.= *' % ( + max_size + 1) + self.assertRegex(res.stderr_text, expected_msg) --=20 2.17.2