From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1gMDWK-0000r9-Qx
	for qemu-devel@nongnu.org; Mon, 12 Nov 2018 09:48:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1gMDWJ-0005U9-Qb
	for qemu-devel@nongnu.org; Mon, 12 Nov 2018 09:48:56 -0500
Date: Mon, 12 Nov 2018 14:48:45 +0000
From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
Message-ID: <20181112144845.GQ3602@redhat.com>
Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
References: <20181005145202.8005-1-berto@igalia.com>
	<w51h8gmbbhi.fsf@maestria.local.igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <w51h8gmbbhi.fsf@maestria.local.igalia.com>
Subject: Re: [Qemu-devel] [PATCH] crypto: Fix defaults in
 QCryptoBlockCreateOptionsLUKS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

On Mon, Nov 12, 2018 at 03:45:45PM +0100, Alberto Garcia wrote:
> ping

Sorry, I should have said I queued this patch when adding my previous R-b.

> On Fri 05 Oct 2018 04:52:02 PM CEST, Alberto Garcia wrote:
> > The values specified in the documentation don't match the actual
> > defaults set in qcrypto_block_luks_create().
> >
> > Signed-off-by: Alberto Garcia <berto@igalia.com>
> > ---
> >  qapi/crypto.json | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/qapi/crypto.json b/qapi/crypto.json
> > index a51b434412..b2a4cff683 100644
> > --- a/qapi/crypto.json
> > +++ b/qapi/crypto.json
> > @@ -181,11 +181,11 @@
> >  # The options that apply to LUKS encryption format initialization
> >  #
> >  # @cipher-alg: the cipher algorithm for data encryption
> > -#              Currently defaults to 'aes'.
> > +#              Currently defaults to 'aes-256'.
> >  # @cipher-mode: the cipher mode for data encryption
> > -#               Currently defaults to 'cbc'
> > +#               Currently defaults to 'xts'
> >  # @ivgen-alg: the initialization vector generator
> > -#             Currently defaults to 'essiv'
> > +#             Currently defaults to 'plain64'
> >  # @ivgen-hash-alg: the initialization vector generator hash
> >  #                  Currently defaults to 'sha256'
> >  # @hash-alg: the master key hash algorithm
> > -- 
> > 2.11.0

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|