qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 02/16] target/arm: Remove antique TODO comment
Date: Mon, 12 Nov 2018 17:08:02 +0000	[thread overview]
Message-ID: <20181112170816.500-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20181112170816.500-1-peter.maydell@linaro.org>

Remove a TODO comment about implementing the vectored interrupt
controller. We have had an implementation of that for a decade;
it's in hw/intc/pl190.c.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20181106164118.16184-1-peter.maydell@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
 target/arm/helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index ec56becc394..851ea9aa977 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -8378,7 +8378,6 @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
         return;
     }
 
-    /* TODO: Vectored interrupt controller.  */
     switch (cs->exception_index) {
     case EXCP_UDEF:
         new_mode = ARM_CPU_MODE_UND;
-- 
2.19.1

  parent reply	other threads:[~2018-11-12 17:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12 17:08 [Qemu-devel] [PULL 00/16] target-arm queue Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 01/16] target/arm: Remove workaround for small SAU regions Peter Maydell
2018-11-12 17:08 ` Peter Maydell [this message]
2018-11-12 17:08 ` [Qemu-devel] [PULL 03/16] MAINTAINERS: Add an entry for the 'collie' machine Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 04/16] hw/arm/sysbus-fdt: Only call match_fn callback if the type matches Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 05/16] target/arm: Fix typo in tlbi_aa64_vmalle1_write Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 06/16] target/arm64: properly handle DBGVR RESS bits Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 07/16] target/arm64: hold BQL when calling do_interrupt() Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 08/16] target/arm64: kvm debug set target_el when passing exception to guest Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 09/16] tests/guest-debug: fix scoping of failcount Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 10/16] arm: use symbolic MDCR_TDE in arm_debug_target_el Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 11/16] arm: fix aa64_generate_debug_exceptions to work with EL2 Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 12/16] Revert "target/arm: Implement HCR.VI and VF" Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 13/16] target/arm: Track the state of our irq lines from the GIC explicitly Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 14/16] target/arm: Correctly implement handling of HCR_EL2.{VI, VF} Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 15/16] target/arm: Hyp mode R14 is shared with User and System Peter Maydell
2018-11-12 17:08 ` [Qemu-devel] [PULL 16/16] target/arm/cpu: Give Cortex-A15 and -A7 the EL2 feature Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112170816.500-3-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).