Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

[xiezhide]

fix two coding style issue

Signed-off-by: x00390961 <xiezhide@huawei.com<mailto:xiezhide@huawei.com>>
---
 fsdev/qemu-fsdev-throttle.c      | 2 +-
 include/qemu/throttle-options.h   | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/fsdev/qemu-fsdev-throttle.c b/fsdev/qemu-fsdev-throttle.c
index 7d313f2..fa2b0c8 100644
--- a/fsdev/qemu-fsdev-throttle.c
+++ b/fsdev/qemu-fsdev-throttle.c
@@ -116,7 +116,7 @@ void fsdev_get_io_throttle(FsThrottle *fst, FsdevIOThrottle **fs9pcfg,
     ThrottleLimits *tlimits;
     FsdevIOThrottle *fscfg = g_malloc(sizeof(*fscfg));
     tlimits = qapi_FsdevIOThrottle_base(fscfg);
-     fscfg->has_id = true;
+    fscfg->has_id = true;
     fscfg->id = g_strdup(fsdevice);
     throttle_config_to_limits(&cfg, tlimits);
     *fs9pcfg = fscfg;
diff --git a/include/qemu/throttle-options.h b/include/qemu/throttle-options.h
index 7134690..3eb1825 100644
--- a/include/qemu/throttle-options.h
+++ b/include/qemu/throttle-options.h
@@ -111,6 +111,5 @@
             .type = QEMU_OPT_NUMBER,\
             .help = "when limiting by iops max size of an I/O in bytes",\
         }
-
     void throttle_parse_options(ThrottleConfig *, QemuOpts *);
 #endif
--
1.8.3.1

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

[Greg Kurz]

On Mon, 12 Nov 2018 01:12:33 +0000
xiezhide <xiezhide@huawei.com> wrote:

> fix two coding style issue
> 

These coding style issues seem to come from patch 1... It is weird to
introduce coding style nits and to fix them afterwards. Just avoid
them in the first place (./scripts/checkpatch.pl is your friend).

> Signed-off-by: x00390961 <xiezhide@huawei.com<mailto:xiezhide@huawei.com>>
> ---
>  fsdev/qemu-fsdev-throttle.c      | 2 +-
>  include/qemu/throttle-options.h   | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fsdev/qemu-fsdev-throttle.c b/fsdev/qemu-fsdev-throttle.c
> index 7d313f2..fa2b0c8 100644
> --- a/fsdev/qemu-fsdev-throttle.c
> +++ b/fsdev/qemu-fsdev-throttle.c
> @@ -116,7 +116,7 @@ void fsdev_get_io_throttle(FsThrottle *fst, FsdevIOThrottle **fs9pcfg,
>      ThrottleLimits *tlimits;
>      FsdevIOThrottle *fscfg = g_malloc(sizeof(*fscfg));
>      tlimits = qapi_FsdevIOThrottle_base(fscfg);
> -     fscfg->has_id = true;
> +    fscfg->has_id = true;
>      fscfg->id = g_strdup(fsdevice);
>      throttle_config_to_limits(&cfg, tlimits);
>      *fs9pcfg = fscfg;
> diff --git a/include/qemu/throttle-options.h b/include/qemu/throttle-options.h
> index 7134690..3eb1825 100644
> --- a/include/qemu/throttle-options.h
> +++ b/include/qemu/throttle-options.h
> @@ -111,6 +111,5 @@
>              .type = QEMU_OPT_NUMBER,\
>              .help = "when limiting by iops max size of an I/O in bytes",\
>          }
> -

I'd rather keep this blank line for better readability.

>      void throttle_parse_options(ThrottleConfig *, QemuOpts *);
>  #endif
> --
> 1.8.3.1
> 

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

[xiezhide]

-----Original Message-----
From: Greg Kurz [mailto:groug@kaod.org] 
Sent: 2018年11月13日 1:55
To: xiezhide <xiezhide@huawei.com>
Cc: qemu-devel@nongnu.org; berto@igalia.com; armbru@redhat.com; dgilbert@redhat.com; aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

On Mon, 12 Nov 2018 01:12:33 +0000
xiezhide <xiezhide@huawei.com> wrote:

> fix two coding style issue
> 

These coding style issues seem to come from patch 1... It is weird to introduce coding style nits and to fix them afterwards. Just avoid them in the first place (./scripts/checkpatch.pl is your friend).

----Thanks for the useful tools

Thanks
Kidd