[Qemu-devel] [PULL for-3.1 0/1] bugfix for s390x

[Qemu-devel] [PULL for-3.1 0/1] bugfix for s390x

[Cornelia Huck]

The following changes since commit 6ff144698935e8bdbc96d255cf49b1a7d54174ac:

  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2018-11-12-tag' into staging (2018-11-13 12:32:30 +0000)

are available in the Git repository at:

  https://github.com/cohuck/qemu tags/s390x-20181114

for you to fetch changes up to b6e67ecc7b6e8938982ab94820c079f24845f623:

  s390x/pci: properly fail if the zPCI device cannot be created (2018-11-13 16:46:55 +0100)

----------------------------------------------------------------
Fix error handling during zpci device creation.

----------------------------------------------------------------

David Hildenbrand (1):
  s390x/pci: properly fail if the zPCI device cannot be created

 hw/s390x/s390-pci-bus.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

-- 
2.17.2

[Qemu-devel] [PULL for-3.1 1/1] s390x/pci: properly fail if the zPCI device cannot be created

[Cornelia Huck]

From: David Hildenbrand <david@redhat.com>

Right now, errors during realize()/pre_plug/plug of the zPCI device
would result in QEMU crashing instead of failing nicely when creating
a zPCI device for a PCI device.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20181113121710.18490-1-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/s390-pci-bus.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index e42e1b80d6..060ff062bc 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -780,17 +780,31 @@ static void s390_pci_msix_free(S390PCIBusDevice *pbdev)
 }
 
 static S390PCIBusDevice *s390_pci_device_new(S390pciState *s,
-                                             const char *target)
+                                             const char *target, Error **errp)
 {
-    DeviceState *dev = NULL;
+    Error *local_err = NULL;
+    DeviceState *dev;
 
     dev = qdev_try_create(BUS(s->bus), TYPE_S390_PCI_DEVICE);
     if (!dev) {
+        error_setg(errp, "zPCI device could not be created");
         return NULL;
     }
 
-    qdev_prop_set_string(dev, "target", target);
-    qdev_init_nofail(dev);
+    object_property_set_str(OBJECT(dev), target, "target", &local_err);
+    if (local_err) {
+        object_unparent(OBJECT(dev));
+        error_propagate_prepend(errp, local_err,
+                                "zPCI device could not be created: ");
+        return NULL;
+    }
+    object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
+    if (local_err) {
+        object_unparent(OBJECT(dev));
+        error_propagate_prepend(errp, local_err,
+                                "zPCI device could not be created: ");
+        return NULL;
+    }
 
     return S390_PCI_DEVICE(dev);
 }
@@ -865,9 +879,8 @@ static void s390_pcihost_hot_plug(HotplugHandler *hotplug_dev,
 
         pbdev = s390_pci_find_dev_by_target(s, dev->id);
         if (!pbdev) {
-            pbdev = s390_pci_device_new(s, dev->id);
+            pbdev = s390_pci_device_new(s, dev->id, errp);
             if (!pbdev) {
-                error_setg(errp, "create zpci device failed");
                 return;
             }
         }
-- 
2.17.2

Re: [Qemu-devel] [PULL for-3.1 0/1] bugfix for s390x

[Peter Maydell]

On 14 November 2018 at 10:16, Cornelia Huck <cohuck@redhat.com> wrote:
> The following changes since commit 6ff144698935e8bdbc96d255cf49b1a7d54174ac:
>
>   Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2018-11-12-tag' into staging (2018-11-13 12:32:30 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/cohuck/qemu tags/s390x-20181114
>
> for you to fetch changes up to b6e67ecc7b6e8938982ab94820c079f24845f623:
>
>   s390x/pci: properly fail if the zPCI device cannot be created (2018-11-13 16:46:55 +0100)
>
> ----------------------------------------------------------------
> Fix error handling during zpci device creation.
>
> ----------------------------------------------------------------
>
> David Hildenbrand (1):
>   s390x/pci: properly fail if the zPCI device cannot be created
>
>  hw/s390x/s390-pci-bus.c | 25 +++++++++++++++++++------
>  1 file changed, 19 insertions(+), 6 deletions(-)
>

Applied, thanks.

-- PMM