From: Peter Xu <peterx@redhat.com>
To: Zhang Chen <zhangckid@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
"zhang.zhanghailiang@huawei.com" <zhang.zhanghailiang@huawei.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
f4bug@amsat.org
Subject: Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication
Date: Thu, 15 Nov 2018 11:43:02 +0800 [thread overview]
Message-ID: <20181115034302.GB27915@xz-x1> (raw)
In-Reply-To: <CAK3tnvK_QinKras3ojAWksVu3otwKZcwAPrhQDmxQq___A2iGA@mail.gmail.com>
On Thu, Nov 15, 2018 at 03:16:25AM +0800, Zhang Chen wrote:
> On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell <peter.maydell@linaro.org>
> wrote:
>
> > On 14 November 2018 at 11:06, Thomas Huth <thuth@redhat.com> wrote:
> > > On 2018-11-14 11:47, Peter Xu wrote:
> > >> On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote:
> > >>> This compilation issue will occur when user use --disable-replication
> > >>> to config Qemu.
> > >>>
> > >>> Reported-by: Thomas Huth <thuth@redhat.com>
> > >>> Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> > >>
> > >> Hi,
> > >>
> > >> How's the status of this patch? Are we gonna merge it for 3.1?
> > >>
> > >> I just posted a similar one without knowing this (until Dave pointed
> > >> it out). IMHO it can be a good candidate for 3.1.
> > >
> > > Maybe Peter Maydell could apply this directly to the repo as a built fix?
> >
> > I'd rather it just went through the migration tree, really...
> > it isn't actually breaking any of our travis jobs or other CI.
> >
> >
> Hi Dave,
>
> What do you think about peter's comments?
AFAIK Juan has queued the v2 of the patch into the next migration
pull, so it'll reach 3.1 soon if nothing goes wrong. Thanks,
--
Peter Xu
next prev parent reply other threads:[~2018-11-15 3:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 2:12 [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication Zhang Chen
2018-11-05 10:02 ` Thomas Huth
2018-11-06 6:44 ` Zhang Chen
2018-11-14 10:47 ` Peter Xu
2018-11-14 11:06 ` Thomas Huth
2018-11-14 11:16 ` Peter Maydell
2018-11-14 19:16 ` Zhang Chen
2018-11-15 3:43 ` Peter Xu [this message]
2018-11-16 18:29 ` Dr. David Alan Gilbert
2018-11-17 14:29 ` Zhang Chen
2018-11-21 11:21 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115034302.GB27915@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).