From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, armbru@redhat.com,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] numa: Match struct to typedef name
Date: Thu, 15 Nov 2018 15:17:52 -0600 [thread overview]
Message-ID: <20181115211752.1295571-3-eblake@redhat.com> (raw)
In-Reply-To: <20181115211752.1295571-1-eblake@redhat.com>
There's no reason to violate our naming conventions by having a
struct with a different name than its typedef. Messed up since
its introduction in commit 8c85901e, but made more obvious when
commit 3bfe5716 promoted it to typedefs.h.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
include/qemu/typedefs.h | 2 +-
include/sysemu/numa.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index 45eab4078eb..a9cfe1b2c2e 100644
--- a/include/qemu/typedefs.h
+++ b/include/qemu/typedefs.h
@@ -61,6 +61,7 @@ typedef struct MSIMessage MSIMessage;
typedef struct NetClientState NetClientState;
typedef struct NetFilterState NetFilterState;
typedef struct NICInfo NICInfo;
+typedef struct NodeInfo NodeInfo;
typedef struct NumaNodeMem NumaNodeMem;
typedef struct PCIBridge PCIBridge;
typedef struct PCIBus PCIBus;
@@ -112,7 +113,6 @@ typedef struct SSIBus SSIBus;
typedef struct uWireSlave uWireSlave;
typedef struct VirtIODevice VirtIODevice;
typedef struct Visitor Visitor;
-typedef struct node_info NodeInfo;
typedef void SaveStateHandler(QEMUFile *f, void *opaque);
typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h
index 21713b7e2f6..b6ac7de43ed 100644
--- a/include/sysemu/numa.h
+++ b/include/sysemu/numa.h
@@ -9,7 +9,7 @@
extern int nb_numa_nodes; /* Number of NUMA nodes */
extern bool have_numa_distance;
-struct node_info {
+struct NodeInfo {
uint64_t node_mem;
struct HostMemoryBackend *node_memdev;
bool present;
--
2.17.2
next prev parent reply other threads:[~2018-11-15 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 21:17 [Qemu-devel] [PATCH 0/2] typedefs.h cleanup Eric Blake
2018-11-15 21:17 ` [Qemu-devel] [PATCH 1/2] typedefs: (Re-)sort entries alphabetically Eric Blake
2018-12-19 8:23 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-11-15 21:17 ` Eric Blake [this message]
2018-11-19 23:20 ` [Qemu-devel] [PATCH 2/2] numa: Match struct to typedef name Eduardo Habkost
2018-11-15 21:28 ` [Qemu-devel] [PATCH 0/2] typedefs.h cleanup Philippe Mathieu-Daudé
2018-11-16 10:14 ` Markus Armbruster
2018-12-18 19:59 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115211752.1295571-3-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).