From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNb8a-0000Rp-GV for qemu-devel@nongnu.org; Fri, 16 Nov 2018 05:14:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNb8X-0005Yo-UO for qemu-devel@nongnu.org; Fri, 16 Nov 2018 05:14:08 -0500 Date: Fri, 16 Nov 2018 11:13:38 +0100 From: "Edgar E. Iglesias" Message-ID: <20181116101338.GW7447@toto> References: <20181115094207.22846-1-luc.michel@greensocs.com> <20181115094207.22846-14-luc.michel@greensocs.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181115094207.22846-14-luc.michel@greensocs.com> Subject: Re: [Qemu-devel] [PATCH v6 13/16] gdbstub: processes initialization on new peer connection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luc Michel Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Peter Maydell , saipava@xilinx.com, edgari@xilinx.com, alistair@alistair23.me, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , mark.burton@greensocs.com, Eduardo Habkost On Thu, Nov 15, 2018 at 10:42:04AM +0100, Luc Michel wrote: > When a new connection is established, we set the first process to be > attached, and the others detached. The first CPU of the first process > is selected as the current CPU. > > Signed-off-by: Luc Michel > Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias > --- > gdbstub.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 0427d1c4f0..59eed3b878 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -2245,13 +2245,14 @@ static bool gdb_accept(void) > close(fd); > return false; > } > > s = g_malloc0(sizeof(GDBState)); > - s->c_cpu = first_cpu; > - s->g_cpu = first_cpu; > create_unique_process(s); > + s->processes[0].attached = true; > + s->c_cpu = gdb_first_cpu(s); > + s->g_cpu = s->c_cpu; > s->fd = fd; > gdb_has_xml = false; > > gdbserver_state = s; > return true; > @@ -2333,12 +2334,23 @@ static void gdb_chr_receive(void *opaque, const uint8_t *buf, int size) > } > } > > static void gdb_chr_event(void *opaque, int event) > { > + int i; > + GDBState *s = (GDBState *) opaque; > + > switch (event) { > case CHR_EVENT_OPENED: > + /* Start with first process attached, others detached */ > + for (i = 0; i < s->process_num; i++) { > + s->processes[i].attached = !i; > + } > + > + s->c_cpu = gdb_first_cpu(s); > + s->g_cpu = s->c_cpu; > + > vm_stop(RUN_STATE_PAUSED); > gdb_has_xml = false; > break; > default: > break; > @@ -2524,19 +2536,17 @@ int gdbserver_start(const char *device) > mon_chr = s->mon_chr; > cleanup_processes(s); > memset(s, 0, sizeof(GDBState)); > s->mon_chr = mon_chr; > } > - s->c_cpu = first_cpu; > - s->g_cpu = first_cpu; > > create_processes(s); > > if (chr) { > qemu_chr_fe_init(&s->chr, chr, &error_abort); > qemu_chr_fe_set_handlers(&s->chr, gdb_chr_can_receive, gdb_chr_receive, > - gdb_chr_event, NULL, NULL, NULL, true); > + gdb_chr_event, NULL, s, NULL, true); > } > s->state = chr ? RS_IDLE : RS_INACTIVE; > s->mon_chr = mon_chr; > s->current_syscall_cb = NULL; > > -- > 2.19.1 >