qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Luc Michel <luc.michel@greensocs.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	"Peter Maydell" <peter.maydell@linaro.org>,
	saipava@xilinx.com, edgari@xilinx.com, alistair@alistair23.me,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	mark.burton@greensocs.com,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension support
Date: Fri, 16 Nov 2018 11:14:38 +0100	[thread overview]
Message-ID: <20181116101438.GY7447@toto> (raw)
In-Reply-To: <20181115094207.22846-16-luc.michel@greensocs.com>

On Thu, Nov 15, 2018 at 10:42:06AM +0100, Luc Michel wrote:
> Add multiprocess extension support by enabling multiprocess mode when
> the peer requests it, and by replying that we actually support it in the
> qSupported reply packet.
> 
> Signed-off-by: Luc Michel <luc.michel@greensocs.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Acked-by: Alistair Francis <alistair.francis@wdc.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> ---
>  gdbstub.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 89819a6a72..e0b844c040 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1721,10 +1721,16 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
>              snprintf(buf, sizeof(buf), "PacketSize=%x", MAX_PACKET_LENGTH);
>              cc = CPU_GET_CLASS(first_cpu);
>              if (cc->gdb_core_xml_file != NULL) {
>                  pstrcat(buf, sizeof(buf), ";qXfer:features:read+");
>              }
> +
> +            if (strstr(p, "multiprocess+")) {
> +                s->multiprocess = true;
> +            }
> +            pstrcat(buf, sizeof(buf), ";multiprocess+");
> +
>              put_packet(s, buf);
>              break;
>          }
>          if (strncmp(p, "Xfer:features:read:", 19) == 0) {
>              const char *xml;
> -- 
> 2.19.1
> 

  reply	other threads:[~2018-11-16 10:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  9:41 [Qemu-devel] [PATCH v6 00/16] gdbstub: support for the multiprocess extension Luc Michel
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 01/16] hw/cpu: introduce CPU clusters Luc Michel
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 02/16] gdbstub: introduce GDB processes Luc Michel
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 03/16] gdbstub: add multiprocess support to '?' packets Luc Michel
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets Luc Michel
2018-11-16  9:51   ` Edgar E. Iglesias
2018-11-19  8:17     ` Luc Michel
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 05/16] gdbstub: add multiprocess support to vCont packets Luc Michel
2018-11-16  9:57   ` Edgar E. Iglesias
2018-11-16 21:51   ` Alistair Francis
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 06/16] gdbstub: add multiprocess support to 'sC' packets Luc Michel
2018-11-16  9:57   ` Edgar E. Iglesias
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo Luc Michel
2018-11-16 10:04   ` Edgar E. Iglesias
2018-11-19 10:12     ` Luc Michel
2018-11-19 16:44       ` Edgar E. Iglesias
2018-11-15  9:41 ` [Qemu-devel] [PATCH v6 08/16] gdbstub: add multiprocess support to Xfer:features:read: Luc Michel
2018-11-16 10:06   ` Edgar E. Iglesias
2018-11-16 21:54   ` Alistair Francis
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 09/16] gdbstub: add multiprocess support to gdb_vm_state_change() Luc Michel
2018-11-16 10:09   ` Edgar E. Iglesias
2018-11-16 21:56   ` Alistair Francis
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 10/16] gdbstub: add multiprocess support to 'D' packets Luc Michel
2018-11-16 10:10   ` Edgar E. Iglesias
2018-11-16 22:00   ` Alistair Francis
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 11/16] gdbstub: add support for extended mode packet Luc Michel
2018-11-16 10:10   ` Edgar E. Iglesias
2018-11-16 22:00   ` Alistair Francis
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 12/16] gdbstub: add support for vAttach packets Luc Michel
2018-11-16 10:11   ` Edgar E. Iglesias
2018-11-16 22:03   ` Alistair Francis
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 13/16] gdbstub: processes initialization on new peer connection Luc Michel
2018-11-16 10:13   ` Edgar E. Iglesias
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached Luc Michel
2018-11-16 10:14   ` Edgar E. Iglesias
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 15/16] gdbstub: add multiprocess extension support Luc Michel
2018-11-16 10:14   ` Edgar E. Iglesias [this message]
2018-11-15  9:42 ` [Qemu-devel] [PATCH v6 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters Luc Michel
2018-11-16 10:15 ` [Qemu-devel] [PATCH v6 00/16] gdbstub: support for the multiprocess extension Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116101438.GY7447@toto \
    --to=edgar.iglesias@xilinx.com \
    --cc=alistair@alistair23.me \
    --cc=edgari@xilinx.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=luc.michel@greensocs.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).