Re: [Qemu-devel] [PATCH 21/22] event-facility: Change SysBusDeviceClass *sbdc to SysBusDeviceClass *sbc

[Cornelia Huck <cohuck@redhat.com>]

On Mon, 19 Nov 2018 20:08:19 +0800
Mao Zhongyi <maozhongyi@cmss.chinamobile.com> wrote:

> Most of the SysBusDeviceClass variables are named sbc,
> and sbdc here is a bit weird, so changing sbdc to keep
> it consistent with others might look good.

A quick git grep also gives sbd and k as variable names, and it is used
in a total of two lines which have not been touched since 2013, so...
meh. If others like the change, I'm not opposed to merging, though.

> 
> Cc: cohuck@redhat.com
> Cc: borntraeger@de.ibm.com
> Cc: rth@twiddle.net
> Cc: david@redhat.com
> Cc: qemu-s390x@nongnu.org
> 
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> ---
>  hw/s390x/event-facility.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index ee5b83448b..759e7bee01 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -484,8 +484,8 @@ static void reset_event_facility(DeviceState *dev)
>  
>  static void init_event_facility_class(ObjectClass *klass, void *data)
>  {
> -    SysBusDeviceClass *sbdc = SYS_BUS_DEVICE_CLASS(klass);
> -    DeviceClass *dc = DEVICE_CLASS(sbdc);
> +    SysBusDeviceClass *sbc = SYS_BUS_DEVICE_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(sbc);
>      SCLPEventFacilityClass *k = EVENT_FACILITY_CLASS(dc);
>  
>      dc->reset = reset_event_facility;