From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker
Date: Mon, 19 Nov 2018 19:23:30 +0100 [thread overview]
Message-ID: <20181119182330.17147-1-pbonzini@redhat.com> (raw)
Nested VMX does not support live migration yet. Add a blocker
until that is worked out.
Nested SVM only does not support it, but unfortunately it is
enabled by default for -cpu host so we cannot really disable it.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/kvm.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index f524e7d929..27dcca5365 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -854,6 +854,7 @@ static int hyperv_init_vcpu(X86CPU *cpu)
}
static Error *invtsc_mig_blocker;
+static Error *vmx_mig_blocker;
#define KVM_MAX_CPUID_ENTRIES 100
@@ -1246,6 +1247,17 @@ int kvm_arch_init_vcpu(CPUState *cs)
!!(c->ecx & CPUID_EXT_SMX);
}
+ if ((env->features[FEAT_1_ECX] & CPUID_EXT_VMX) && !vmx_mig_blocker) {
+ error_setg(&vmx_mig_blocker,
+ "Nested VMX virtualization does not support live migration yet");
+ r = migrate_add_blocker(vmx_mig_blocker, &local_err);
+ if (local_err) {
+ error_report_err(local_err);
+ error_free(vmx_mig_blocker);
+ return r;
+ }
+ }
+
if (env->mcg_cap & MCG_LMCE_P) {
has_msr_mcg_ext_ctl = has_msr_feature_control = true;
}
--
2.19.1
next reply other threads:[~2018-11-19 18:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 18:23 Paolo Bonzini [this message]
2018-11-20 11:44 ` [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker Dr. David Alan Gilbert
2018-11-20 12:14 ` Paolo Bonzini
2019-04-10 18:26 ` Cole Robinson
2019-04-10 18:26 ` Cole Robinson
2019-04-12 7:47 ` Paolo Bonzini
2019-04-12 7:47 ` Paolo Bonzini
2019-04-12 18:33 ` Cole Robinson
2019-04-12 18:33 ` Cole Robinson
2019-04-13 8:26 ` [Qemu-devel] R: " Paolo Bonzini
2019-04-13 8:26 ` Paolo Bonzini
2019-04-15 11:22 ` Dr. David Alan Gilbert
2019-04-15 11:22 ` Dr. David Alan Gilbert
2019-04-15 11:26 ` Paolo Bonzini
2019-04-15 11:26 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119182330.17147-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).