qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Andrea Bolognani" <abologna@redhat.com>,
	qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Amit Shah" <amit@kernel.org>, "Cleber Rosa" <crosa@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Fam Zheng" <famz@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	libvir-list@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
	"Laine Stump" <laine@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Caio Carrara" <ccarrara@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices
Date: Tue, 20 Nov 2018 11:35:02 +0100	[thread overview]
Message-ID: <20181120113502.175c81ed.cohuck@redhat.com> (raw)
In-Reply-To: <20181119213232.GE3807@habkost.net>

On Mon, 19 Nov 2018 19:32:32 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> However, I wish this kind of usability magic didn't automatically
> imposed us the burden of keeping guest ABI compatibility too.
> Keeping ABI compatibility on the machine-friendly device types and
> interfaces is already hard enough.

Hm, what are you thinking about here? We can fence off new features in
the hw compat section (and we already do so today), so the remaining
compat woe is what you are addressing with this patch set, isn't it?

> 
> We already have aliases that automatically select a virtio device
> type at qdev-monitor.c:qdev_alias_table[], and I don't know if
> they are supposed to keep a stable guest ABI.

As the comment there states, it was a bad idea... when you are using
the alias, you can't pass any properties that are unique to the
transport anyway. Hopefully the compat code dealt with the
disable-modern for old machine types correctly in this case; but I
don't think that helps for the bus dilemma.

I'm not sure we want to worry about the aliases too much; it might even
be a good idea to deprecate them.

  reply	other threads:[~2018-11-20 10:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 23:38 [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices Eduardo Habkost
2018-11-15  8:40 ` no-reply
2018-11-15 10:05 ` Daniel P. Berrangé
2018-11-15 10:50   ` Cornelia Huck
2018-11-15 10:52     ` Daniel P. Berrangé
2018-11-20  0:44     ` Eduardo Habkost
2018-11-20 10:46       ` Daniel P. Berrangé
2018-11-20 10:52       ` Cornelia Huck
2018-11-20 11:51         ` Eduardo Habkost
2018-11-15 11:21 ` Cornelia Huck
2018-11-15 15:01   ` Cornelia Huck
2018-11-27  0:35   ` Eduardo Habkost
2018-11-15 16:29 ` Andrea Bolognani
2018-11-16  3:45   ` Eduardo Habkost
2018-11-19 10:41     ` Cornelia Huck
2018-11-19 18:07       ` Michael S. Tsirkin
2018-11-19 18:32         ` Cornelia Huck
2018-11-19 18:42           ` Michael S. Tsirkin
2018-11-19 18:56             ` Cornelia Huck
2018-11-19 19:14               ` Michael S. Tsirkin
2018-11-20 12:27                 ` Andrea Bolognani
2018-11-20 19:14                   ` Michael S. Tsirkin
2018-11-21 16:20                     ` Andrea Bolognani
2018-11-19 21:32               ` Eduardo Habkost
2018-11-20 10:35                 ` Cornelia Huck [this message]
2018-11-19 21:47         ` Eduardo Habkost
2018-11-20  3:08           ` Michael S. Tsirkin
2018-11-20  3:22             ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120113502.175c81ed.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=abologna@redhat.com \
    --cc=amit@kernel.org \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ccarrara@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laine@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).