From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP94q-00008e-Vn for qemu-devel@nongnu.org; Tue, 20 Nov 2018 11:40:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP94m-0005Mr-B0 for qemu-devel@nongnu.org; Tue, 20 Nov 2018 11:40:39 -0500 Date: Tue, 20 Nov 2018 17:40:10 +0100 From: Igor Mammedov Message-ID: <20181120174010.3999adda@redhat.com> In-Reply-To: <20181107123652.23417-6-marcandre.lureau@redhat.com> References: <20181107123652.23417-1-marcandre.lureau@redhat.com> <20181107123652.23417-6-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-3.2 v3 05/14] qdev: move qdev_prop_register_global_list() to tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, Peter Maydell , Stefano Stabellini , xen-devel@lists.xenproject.org, Corey Minyard , Amit Shah , =?UTF-8?B?SGVy?= =?UTF-8?B?dsOp?= Poussineau , "Michael S. Tsirkin" , Mark Cave-Ayland , dgilbert@redhat.com, Eduardo Habkost , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Anthony Perard , Paolo Bonzini , Stefan Berger , Andreas =?UTF-8?B?RsOkcmJlcg==?= , Artyom Tarasenko , Richard Henderson On Wed, 7 Nov 2018 16:36:43 +0400 Marc-Andr=C3=A9 Lureau wrote: > The function is only used by a test, move it there. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > include/hw/qdev-properties.h | 1 - > hw/core/qdev-properties.c | 9 --------- > tests/test-qdev-global-props.c | 18 ++++++++++++++---- > 3 files changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index a95f4a73eb..3ab9cd2eb6 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -249,7 +249,6 @@ void qdev_prop_set_enum(DeviceState *dev, const char = *name, int value); > void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value); > =20 > void qdev_prop_register_global(GlobalProperty *prop); > -void qdev_prop_register_global_list(GlobalProperty *props); > int qdev_prop_check_globals(void); > void qdev_prop_set_globals(DeviceState *dev); > void error_set_from_qdev_prop_error(Error **errp, int ret, DeviceState *= dev, > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index ab61d502fd..bd84c4ea4c 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -1180,15 +1180,6 @@ void qdev_prop_register_global(GlobalProperty *pro= p) > global_props =3D g_list_append(global_props, prop); > } > =20 > -void qdev_prop_register_global_list(GlobalProperty *props) > -{ > - int i; > - > - for (i =3D 0; props[i].driver !=3D NULL; i++) { > - qdev_prop_register_global(props+i); > - } > -} > - > int qdev_prop_check_globals(void) > { > GList *l; > diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-prop= s.c > index ccdf6c57c1..b1eb505442 100644 > --- a/tests/test-qdev-global-props.c > +++ b/tests/test-qdev-global-props.c > @@ -89,6 +89,16 @@ static void test_static_prop(void) > g_test_trap_assert_stdout(""); > } > =20 > +static void register_global_properties(GlobalProperty *props) > +{ > + int i; > + > + for (i =3D 0; props[i].driver !=3D NULL; i++) { > + qdev_prop_register_global(props + i); > + } > +} > + > + > /* Test setting of static property using global properties */ > static void test_static_globalprop_subprocess(void) > { > @@ -98,7 +108,7 @@ static void test_static_globalprop_subprocess(void) > {} > }; > =20 > - qdev_prop_register_global_list(props); > + register_global_properties(props); > =20 > mt =3D STATIC_TYPE(object_new(TYPE_STATIC_PROPS)); > qdev_init_nofail(DEVICE(mt)); > @@ -216,7 +226,7 @@ static void test_dynamic_globalprop_subprocess(void) > }; > int global_error; > =20 > - qdev_prop_register_global_list(props); > + register_global_properties(props); > =20 > mt =3D DYNAMIC_TYPE(object_new(TYPE_DYNAMIC_PROPS)); > qdev_init_nofail(DEVICE(mt)); > @@ -261,7 +271,7 @@ static void test_dynamic_globalprop_nouser_subprocess= (void) > }; > int global_error; > =20 > - qdev_prop_register_global_list(props); > + register_global_properties(props); > =20 > mt =3D DYNAMIC_TYPE(object_new(TYPE_DYNAMIC_PROPS)); > qdev_init_nofail(DEVICE(mt)); > @@ -299,7 +309,7 @@ static void test_subclass_global_props(void) > {} > }; > =20 > - qdev_prop_register_global_list(props); > + register_global_properties(props); > =20 > mt =3D STATIC_TYPE(object_new(TYPE_SUBCLASS)); > qdev_init_nofail(DEVICE(mt));