From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPEwk-00088u-5u for qemu-devel@nongnu.org; Tue, 20 Nov 2018 17:56:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPEt2-0002g0-5z for qemu-devel@nongnu.org; Tue, 20 Nov 2018 17:52:54 -0500 From: Eric Blake Date: Tue, 20 Nov 2018 16:52:41 -0600 Message-Id: <20181120225241.2371769-1-eblake@redhat.com> Subject: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org, Max Reitz The use of TLS while building qemu is optional. While the 'certtool' binary should be available on every platform that supports building against TLS, that does not imply that the developer has installed it. Make the test gracefully skip in that case. Reported-by: Kevin Wolf Signed-off-by: Eric Blake --- On Fedora, libvirt requires libtls-utils to be present, but not qemu. I'm fine if Kevin wants to pick this up in a pull request related to iotests in general; if not, I'll do a pull request through my NBD tree in time for -rc3. tests/qemu-iotests/common.tls | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/common.tls b/tests/qemu-iotests/common.tls index 39f17c1b999..eae81789bbc 100644 --- a/tests/qemu-iotests/common.tls +++ b/tests/qemu-iotests/common.tls @@ -31,6 +31,9 @@ tls_x509_cleanup() tls_x509_init() { + (certtool --help) >/dev/null 2>&1 || \ + _notrun "certtool utility not found, skipping test" + mkdir -p "${tls_dir}" # use a fixed key so we don't waste system entropy on -- 2.17.2