* Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed
2018-11-20 22:52 [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed Eric Blake
@ 2018-11-20 23:11 ` Eric Blake
2018-11-20 23:22 ` [Qemu-devel] [Qemu-block] " John Snow
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2018-11-20 23:11 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, qemu-block, Max Reitz
On 11/20/18 4:52 PM, Eric Blake wrote:
> The use of TLS while building qemu is optional. While the
> 'certtool' binary should be available on every platform that
> supports building against TLS, that does not imply that the
> developer has installed it. Make the test gracefully skip
> in that case.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> On Fedora, libvirt requires libtls-utils to be present, but not qemu.
Sorry for the typo; certtool is part of gnutls-utils
>
> I'm fine if Kevin wants to pick this up in a pull request related
> to iotests in general; if not, I'll do a pull request through my
> NBD tree in time for -rc3.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Skip 233 if certtool not installed
2018-11-20 22:52 [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed Eric Blake
2018-11-20 23:11 ` Eric Blake
@ 2018-11-20 23:22 ` John Snow
2018-11-21 9:31 ` [Qemu-devel] " Kevin Wolf
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2018-11-20 23:22 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: kwolf, berrange, qemu-block, Max Reitz
On 11/20/18 5:52 PM, Eric Blake wrote:
> The use of TLS while building qemu is optional. While the
> 'certtool' binary should be available on every platform that
> supports building against TLS, that does not imply that the
> developer has installed it. Make the test gracefully skip
> in that case.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
>
> On Fedora, libvirt requires libtls-utils to be present, but not qemu.
>
> I'm fine if Kevin wants to pick this up in a pull request related
> to iotests in general; if not, I'll do a pull request through my
> NBD tree in time for -rc3.
>
> tests/qemu-iotests/common.tls | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/common.tls b/tests/qemu-iotests/common.tls
> index 39f17c1b999..eae81789bbc 100644
> --- a/tests/qemu-iotests/common.tls
> +++ b/tests/qemu-iotests/common.tls
> @@ -31,6 +31,9 @@ tls_x509_cleanup()
>
> tls_x509_init()
> {
> + (certtool --help) >/dev/null 2>&1 || \
> + _notrun "certtool utility not found, skipping test"
> +
Or something wickedly foul has happened :)
> mkdir -p "${tls_dir}"
>
> # use a fixed key so we don't waste system entropy on
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed
2018-11-20 22:52 [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed Eric Blake
2018-11-20 23:11 ` Eric Blake
2018-11-20 23:22 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2018-11-21 9:31 ` Kevin Wolf
2018-11-21 9:32 ` Daniel P. Berrangé
2018-11-21 12:06 ` Wainer dos Santos Moschetta
4 siblings, 0 replies; 6+ messages in thread
From: Kevin Wolf @ 2018-11-21 9:31 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, berrange, qemu-block, Max Reitz
Am 20.11.2018 um 23:52 hat Eric Blake geschrieben:
> The use of TLS while building qemu is optional. While the
> 'certtool' binary should be available on every platform that
> supports building against TLS, that does not imply that the
> developer has installed it. Make the test gracefully skip
> in that case.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed
2018-11-20 22:52 [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed Eric Blake
` (2 preceding siblings ...)
2018-11-21 9:31 ` [Qemu-devel] " Kevin Wolf
@ 2018-11-21 9:32 ` Daniel P. Berrangé
2018-11-21 12:06 ` Wainer dos Santos Moschetta
4 siblings, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2018-11-21 9:32 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, Max Reitz
On Tue, Nov 20, 2018 at 04:52:41PM -0600, Eric Blake wrote:
> The use of TLS while building qemu is optional. While the
> 'certtool' binary should be available on every platform that
> supports building against TLS, that does not imply that the
> developer has installed it. Make the test gracefully skip
> in that case.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> On Fedora, libvirt requires libtls-utils to be present, but not qemu.
>
> I'm fine if Kevin wants to pick this up in a pull request related
> to iotests in general; if not, I'll do a pull request through my
> NBD tree in time for -rc3.
>
> tests/qemu-iotests/common.tls | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed
2018-11-20 22:52 [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed Eric Blake
` (3 preceding siblings ...)
2018-11-21 9:32 ` Daniel P. Berrangé
@ 2018-11-21 12:06 ` Wainer dos Santos Moschetta
4 siblings, 0 replies; 6+ messages in thread
From: Wainer dos Santos Moschetta @ 2018-11-21 12:06 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, Max Reitz
On 11/20/2018 08:52 PM, Eric Blake wrote:
> The use of TLS while building qemu is optional. While the
> 'certtool' binary should be available on every platform that
> supports building against TLS, that does not imply that the
> developer has installed it. Make the test gracefully skip
> in that case.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
>
> On Fedora, libvirt requires libtls-utils to be present, but not qemu.
>
> I'm fine if Kevin wants to pick this up in a pull request related
> to iotests in general; if not, I'll do a pull request through my
> NBD tree in time for -rc3.
>
> tests/qemu-iotests/common.tls | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/common.tls b/tests/qemu-iotests/common.tls
> index 39f17c1b999..eae81789bbc 100644
> --- a/tests/qemu-iotests/common.tls
> +++ b/tests/qemu-iotests/common.tls
> @@ -31,6 +31,9 @@ tls_x509_cleanup()
>
> tls_x509_init()
> {
> + (certtool --help) >/dev/null 2>&1 || \
> + _notrun "certtool utility not found, skipping test"
> +
> mkdir -p "${tls_dir}"
>
> # use a fixed key so we don't waste system entropy on
^ permalink raw reply [flat|nested] 6+ messages in thread