* [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks
@ 2018-11-14 19:09 Zhang Chen
2018-11-15 3:54 ` Peter Xu
2018-11-21 11:38 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 4+ messages in thread
From: Zhang Chen @ 2018-11-14 19:09 UTC (permalink / raw)
To: Dr . David Alan Gilbert, Juan Quintela, qemu-dev; +Cc: Zhang Chen
From: Zhang Chen <chen.zhang@intel.com>
Current COLO mode(independent disk mode) need replication module work
together. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com>.
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
migration/migration.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index b261c1e4ce..49ffb9997a 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -918,6 +918,15 @@ static bool migrate_caps_check(bool *cap_list,
}
#endif
+#ifndef CONFIG_REPLICATION
+ if (cap_list[MIGRATION_CAPABILITY_X_COLO]) {
+ error_setg(errp, "QEMU compiled without replication module"
+ " can't enable COLO");
+ error_append_hint(errp, "Please enable replication before COLO.\n");
+ return false;
+ }
+#endif
+
if (cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM]) {
if (cap_list[MIGRATION_CAPABILITY_COMPRESS]) {
/* The decompression threads asynchronously write into RAM
--
2.17.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks
2018-11-14 19:09 [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks Zhang Chen
@ 2018-11-15 3:54 ` Peter Xu
2018-11-21 9:50 ` Zhang Chen
2018-11-21 11:38 ` Dr. David Alan Gilbert
1 sibling, 1 reply; 4+ messages in thread
From: Peter Xu @ 2018-11-15 3:54 UTC (permalink / raw)
To: Zhang Chen; +Cc: Dr . David Alan Gilbert, Juan Quintela, qemu-dev
On Thu, Nov 15, 2018 at 03:09:12AM +0800, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Current COLO mode(independent disk mode) need replication module work
> together. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com>.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Regards,
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks
2018-11-15 3:54 ` Peter Xu
@ 2018-11-21 9:50 ` Zhang Chen
0 siblings, 0 replies; 4+ messages in thread
From: Zhang Chen @ 2018-11-21 9:50 UTC (permalink / raw)
To: peterx; +Cc: Zhang Chen, qemu-devel, Dr . David Alan Gilbert, Juan Quintela
On Thu, Nov 15, 2018 at 11:55 AM Peter Xu <peterx@redhat.com> wrote:
> On Thu, Nov 15, 2018 at 03:09:12AM +0800, Zhang Chen wrote:
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > Current COLO mode(independent disk mode) need replication module work
> > together. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com>.
> >
> > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
>
>
Thanks Peter,
any comments from others?
Thanks
Zhang Chen
> Regards,
>
> --
> Peter Xu
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks
2018-11-14 19:09 [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks Zhang Chen
2018-11-15 3:54 ` Peter Xu
@ 2018-11-21 11:38 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2018-11-21 11:38 UTC (permalink / raw)
To: Zhang Chen; +Cc: Juan Quintela, qemu-dev
* Zhang Chen (chen.zhang@intel.com) wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Current COLO mode(independent disk mode) need replication module work
> together. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com>.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Queued
> ---
> migration/migration.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index b261c1e4ce..49ffb9997a 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -918,6 +918,15 @@ static bool migrate_caps_check(bool *cap_list,
> }
> #endif
>
> +#ifndef CONFIG_REPLICATION
> + if (cap_list[MIGRATION_CAPABILITY_X_COLO]) {
> + error_setg(errp, "QEMU compiled without replication module"
> + " can't enable COLO");
> + error_append_hint(errp, "Please enable replication before COLO.\n");
> + return false;
> + }
> +#endif
> +
> if (cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM]) {
> if (cap_list[MIGRATION_CAPABILITY_COMPRESS]) {
> /* The decompression threads asynchronously write into RAM
> --
> 2.17.GIT
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-21 11:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-14 19:09 [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks Zhang Chen
2018-11-15 3:54 ` Peter Xu
2018-11-21 9:50 ` Zhang Chen
2018-11-21 11:38 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).