From: Gerd Hoffmann <kraxel@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size
Date: Wed, 21 Nov 2018 14:07:43 +0100 [thread overview]
Message-ID: <20181121130743.3wz5ggbwslj4fwmd@sirius.home.kraxel.org> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1811211613440.4176@xnncv>
On Wed, Nov 21, 2018 at 04:19:11PM +0530, P J P wrote:
> Hello Gerd,
>
> +-- On Mon, 12 Nov 2018, Gerd Hoffmann wrote --+
> | On Tue, Oct 30, 2018 at 09:23:40AM +0100, Gerd Hoffmann wrote:
> | > Fixes: CVE-2018-???
> | > Cc: P J P <ppandit@redhat.com>
> |
> | ping, do we have a cve number meanwhile?
>
> No, the off-by-one does not seem to have an adverse effect. One byte past
> AR_TABLE[75] array would likely read into DR_TABLE[75] array, which would
> anyway be accessible to a driver. It does not seem to crash Qemu either. I
> think it's more of a bug fix, than security fix. Hope that's okay.
Ok, makes sense, I'll drop the cve line then and queue the patch.
cheers,
Gerd
next prev parent reply other threads:[~2018-11-21 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 8:23 [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size Gerd Hoffmann
2018-10-30 8:45 ` Philippe Mathieu-Daudé
2018-10-31 5:02 ` no-reply
2018-10-31 14:10 ` Philippe Mathieu-Daudé
2018-11-12 13:18 ` Gerd Hoffmann
2018-11-21 10:49 ` P J P
2018-11-21 13:07 ` Gerd Hoffmann [this message]
2018-11-27 7:30 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121130743.3wz5ggbwslj4fwmd@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).