From: Kevin Wolf <kwolf@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Fix crash if underlying host file or disk returns error.
Date: Wed, 21 Nov 2018 15:20:23 +0100 [thread overview]
Message-ID: <20181121142023.GC4030@linux.fritz.box> (raw)
In-Reply-To: <20181121124747.30696-1-rjones@redhat.com>
Am 21.11.2018 um 13:47 hat Richard W.M. Jones geschrieben:
> Commit 40dce4ee6 "scsi-disk: fix rerror/werror=ignore" introduced a
> bug which causes qemu to crash with the assertion error below if the
> host file or disk returns an error:
>
> qemu-system-x86_64: hw/scsi/scsi-bus.c:1374: scsi_req_complete:
> Assertion `req->status == -1' failed.
>
> Kevin Wolf suggested this fix:
>
> < kwolf> Hm, should the final return false; in that patch
> actually be a return true?
> < kwolf> Because I think he didn't intend to change anything
> except BLOCK_ERROR_ACTION_IGNORE
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1804323
Thanks, applied to the block branch.
Kevin
next prev parent reply other threads:[~2018-11-21 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 12:47 [Qemu-devel] [PATCH] scsi-disk: Fix crash if underlying host file or disk returns error Richard W.M. Jones
2018-11-21 14:20 ` Kevin Wolf [this message]
2018-11-21 18:31 ` Paolo Bonzini
2018-11-22 10:30 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121142023.GC4030@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).