Re: [Qemu-devel] [PATCH V7 4/6] hw/arm/virt: Use the pvpanic device

[<peng.hao2@zte.com.cn>]

> >  Add pvpanic device in arm virt machine.
> >
> > Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> >  default-configs/arm-softmmu.mak |  1 +
> >  hw/arm/virt.c                   | 21 +++++++++++++++++++++
> >  include/hw/arm/virt.h           |  1 +
> >  3 files changed, 23 insertions(+)
> >
> > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> > index 2420491..50345df 100644
> > --- a/default-configs/arm-softmmu.mak
> > +++ b/default-configs/arm-softmmu.mak
> > @@ -159,3 +159,4 @@ CONFIG_PCI_DESIGNWARE=y
> >  CONFIG_STRONGARM=y
> >  CONFIG_HIGHBANK=y
> >  CONFIG_MUSICPAL=y
> > +CONFIG_PVPANIC=y
> > diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> > index 9f67782..c4f29c8 100644
[...]
> > +                            "compatible", "qemu,pvpanic-mmio");
> > +    qemu_fdt_setprop_sized_cells(vms->fdt, nodename, "reg",
> > +                                 2, base, 2, size);
> 
> Note that we can't take these patches into QEMU until the device
> tree binding has been agreed upstream and accepted into the kernel.
> 
kernel part : https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/log/?h=char-misc-next
> > +    g_free(nodename);
> > +}
> > +
> >  static void create_fdt(VirtMachineState *vms)
> >  {
> >      void *fdt = create_device_tree(&vms->fdt_size);
> > @@ -1531,6 +1550,8 @@ static void machvirt_init(MachineState *machine)
> >
> >      create_flash(vms, sysmem, secure_sysmem ? secure_sysmem : sysmem);
> >
> > +    create_pvpanic_device(vms);
> > +
> >      create_gic(vms, pic);
> 
> As Shannon suggests, we should not be creating this device by default.
I'm  just working for that. 
Thanks.
> 
> thanks
> -- PMM