From: Kevin Wolf <kwolf@redhat.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: keith.busch@intel.com, mreitz@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/nvme: call blk_drain in NVMe reset code to avoid lockups
Date: Thu, 22 Nov 2018 15:32:43 +0100 [thread overview]
Message-ID: <20181122143243.GC31879@linux.fritz.box> (raw)
In-Reply-To: <1541506615-30202-1-git-send-email-igor.druzhinin@citrix.com>
Am 06.11.2018 um 13:16 hat Igor Druzhinin geschrieben:
> When blk_flush called in NVMe reset path S/C queues are already freed
> which means that re-entering AIO handling loop having some IO requests
> unfinished will lockup or crash as their SG structures being potentially
> reused. Call blk_drain before freeing the queues to avoid this nasty
> scenario.
>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2018-11-22 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 12:16 [Qemu-devel] [PATCH] block/nvme: call blk_drain in NVMe reset code to avoid lockups Igor Druzhinin
2018-11-14 17:42 ` Igor Druzhinin
2018-11-20 17:31 ` Igor Druzhinin
2018-11-20 17:52 ` Paolo Bonzini
2018-11-22 14:32 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122143243.GC31879@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=igor.druzhinin@citrix.com \
--cc=keith.busch@intel.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).