From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPqNL-0005Dk-Rk for qemu-devel@nongnu.org; Thu, 22 Nov 2018 09:54:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPqNK-0004l7-2o for qemu-devel@nongnu.org; Thu, 22 Nov 2018 09:54:39 -0500 Date: Thu, 22 Nov 2018 15:54:29 +0100 From: Kevin Wolf Message-ID: <20181122145429.GD31879@linux.fritz.box> References: <20181120184148.22501-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181120184148.22501-1-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] nvme: fix out-of-bounds access to the CMB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, mreitz@redhat.com, Li Qiang , Keith Busch , qemu-block@nongnu.org Am 20.11.2018 um 19:41 hat Paolo Bonzini geschrieben: > Because the CMB BAR has a min_access_size of 2, if you read the last > byte it will try to memcpy *2* bytes from n->cmbuf, causing an off-by-one > error. This is CVE-2018-16847. > > Another way to fix this might be to register the CMB as a RAM memory > region, which would also be more efficient. However, that might be a > change for big-endian machines; I didn't think this through and I don't > know how real hardware works. Add a basic testcase for the CMB in case > somebody does this change later on. > > Cc: Keith Busch > Cc: qemu-block@nongnu.org > Reported-by: Li Qiang > Reviewed-by: Li Qiang > Tested-by: Li Qiang > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch and reverted 5e3c0220d7. Kevin