qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luc Michel <luc.michel@greensocs.com>
To: qemu-devel@nongnu.org
Cc: "Luc Michel" <luc.michel@greensocs.com>,
	qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	saipava@xilinx.com, edgari@xilinx.com, alistair@alistair23.me,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	mark.burton@greensocs.com,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH v7 06/16] gdbstub: add multiprocess support to 'sC' packets
Date: Fri, 23 Nov 2018 10:17:19 +0100	[thread overview]
Message-ID: <20181123091729.29921-7-luc.michel@greensocs.com> (raw)
In-Reply-To: <20181123091729.29921-1-luc.michel@greensocs.com>

Change the sC packet handling to support the multiprocess extension.
Instead of returning the first thread, we return the first thread of the
current process.

Signed-off-by: Luc Michel <luc.michel@greensocs.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 gdbstub.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 691b877aa8..728efdabee 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1548,13 +1548,18 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
             type = strtoul(p, (char **)&p, 16);
             sstep_flags = type;
             put_packet(s, "OK");
             break;
         } else if (strcmp(p,"C") == 0) {
-            /* "Current thread" remains vague in the spec, so always return
-             *  the first CPU (gdb returns the first thread). */
-            put_packet(s, "QC1");
+            /* "Current thread" remains vague in the spec, so always return the
+             * first thread of the current process (gdb returns the first
+             * thread).
+             */
+            cpu = get_first_cpu_in_process(s, gdb_get_cpu_process(s, s->g_cpu));
+            snprintf(buf, sizeof(buf), "QC%s",
+                     gdb_fmt_thread_id(s, cpu, thread_id, sizeof(thread_id)));
+            put_packet(s, buf);
             break;
         } else if (strcmp(p,"fThreadInfo") == 0) {
             s->query_cpu = first_cpu;
             goto report_cpuinfo;
         } else if (strcmp(p,"sThreadInfo") == 0) {
-- 
2.19.1

  parent reply	other threads:[~2018-11-23  9:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23  9:17 [Qemu-devel] [PATCH v7 00/16] gdbstub: support for the multiprocess extension Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters Luc Michel
2018-11-23 18:10   ` Eduardo Habkost
2018-11-23 18:14     ` Peter Maydell
2018-11-23 18:24       ` Eduardo Habkost
2018-11-23 18:53         ` Peter Maydell
2018-11-23 22:38           ` Eduardo Habkost
2018-11-25 21:27     ` Philippe Mathieu-Daudé
2018-11-26 13:27       ` Eduardo Habkost
2018-11-30 16:52         ` Peter Maydell
2018-11-30 18:14           ` Eduardo Habkost
2018-12-03 11:20           ` Luc Michel
2018-12-03 11:23             ` Peter Maydell
2018-12-03 14:09               ` Luc Michel
2018-12-04 18:06                 ` Eduardo Habkost
2018-12-04 18:24                   ` Peter Maydell
2018-12-04 19:05                     ` Eduardo Habkost
2018-12-04 19:16                       ` Peter Maydell
2018-12-04 19:45                         ` Eduardo Habkost
2018-12-05 14:02                           ` Luc Michel
2018-12-05 16:47                             ` Eduardo Habkost
2018-12-05 13:44                     ` Luc Michel
2018-12-05 13:47                   ` Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 02/16] gdbstub: introduce GDB processes Luc Michel
2018-11-25 20:58   ` Philippe Mathieu-Daudé
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 03/16] gdbstub: add multiprocess support to '?' packets Luc Michel
2018-11-25 21:22   ` Philippe Mathieu-Daudé
2018-12-06 12:27     ` Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 05/16] gdbstub: add multiprocess support to vCont packets Luc Michel
2018-11-23  9:17 ` Luc Michel [this message]
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo Luc Michel
2018-11-30 10:35   ` Edgar E. Iglesias
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 08/16] gdbstub: add multiprocess support to Xfer:features:read: Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 09/16] gdbstub: add multiprocess support to gdb_vm_state_change() Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 10/16] gdbstub: add multiprocess support to 'D' packets Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 11/16] gdbstub: add support for extended mode packet Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 12/16] gdbstub: add support for vAttach packets Luc Michel
2018-11-25 21:00   ` Philippe Mathieu-Daudé
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 13/16] gdbstub: processes initialization on new peer connection Luc Michel
2018-11-25 21:02   ` Philippe Mathieu-Daudé
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 15/16] gdbstub: add multiprocess extension support Luc Michel
2018-11-23  9:17 ` [Qemu-devel] [PATCH v7 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters Luc Michel
2018-11-25 21:10   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123091729.29921-7-luc.michel@greensocs.com \
    --to=luc.michel@greensocs.com \
    --cc=alistair@alistair23.me \
    --cc=edgari@xilinx.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).