From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom()
Date: Fri, 23 Nov 2018 10:59:21 -0500 [thread overview]
Message-ID: <20181123105915-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20181122133507.30950-1-peter.maydell@linaro.org>
On Thu, Nov 22, 2018 at 01:35:05PM +0000, Peter Maydell wrote:
> The API of cpu_physical_memory_write_rom() is odd, because it
> takes an AddressSpace, unlike all the other cpu_physical_memory_*
> access functions. We note this oddity as a TODO in the
> docs/devel/loads-stores.rst documentation.
>
> Rename cpu_physical_memory_write_rom() to address_space_write_rom(),
> and give it an API that matches address_space_write().
> We also adjest the cpu_physical_memory_write_rom_internal()
> function which is local to exec.c similarly.
>
> thanks
> -- PMM
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Peter Maydell (2):
> exec.c: Rename cpu_physical_memory_write_rom_internal()
> Rename cpu_physical_memory_write_rom() to address_space_write_rom()
>
> include/exec/cpu-common.h | 2 --
> include/exec/memory.h | 26 ++++++++++++++++++++++++++
> exec.c | 30 +++++++++++++++++++-----------
> hw/core/loader.c | 4 ++--
> hw/intc/apic.c | 7 ++++---
> hw/misc/tz-mpc.c | 2 +-
> hw/sparc/sun4m.c | 5 +++--
> docs/devel/loads-stores.rst | 35 ++++++++++++++++-------------------
> 8 files changed, 71 insertions(+), 40 deletions(-)
>
> --
> 2.19.1
next prev parent reply other threads:[~2018-11-23 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 13:35 [Qemu-devel] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom() Peter Maydell
2018-11-22 13:35 ` [Qemu-devel] [PATCH for-4.0 1/2] exec.c: Rename cpu_physical_memory_write_rom_internal() Peter Maydell
2018-11-22 13:35 ` [Qemu-devel] [PATCH for-4.0 2/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom() Peter Maydell
2018-11-22 16:48 ` [Qemu-devel] [PATCH for-4.0 0/2] " Philippe Mathieu-Daudé
2018-11-23 15:59 ` Michael S. Tsirkin [this message]
2018-12-14 11:32 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-12-14 11:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123105915-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).