From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, sameo@linux.intel.com, drjones@redhat.com,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations
Date: Fri, 23 Nov 2018 11:11:50 -0500 [thread overview]
Message-ID: <20181123111017-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1542882574-109418-1-git-send-email-imammedo@redhat.com>
On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote:
> * arm/virt is broken but it looks like linux doesn't care, lets fix it anyways
> * x86, got lucky since we didn't use extended fields,
> fix it so that it will calculate checksum using correct length
> so that it would be easier to unify arm/x86 into one impl.
>
I'd say patch 2 should go into this release.
What about patch 1? It's cosmetic and it isn't the best we can do.
Let me know whether you agree.
> Igor Mammedov (2):
> pc: acpi: use correct RSDT length for checksum
> arm/virt: acpi: fix incorrect checksums in RSDP
>
> hw/arm/virt-acpi-build.c | 7 ++++++-
> hw/i386/acpi-build.c | 2 +-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> --
> 2.7.4
next prev parent reply other threads:[~2018-11-23 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 10:29 [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations Igor Mammedov
2018-11-22 10:29 ` [Qemu-devel] [PATCH 1/2] pc: acpi: use correct RSDT length for checksum Igor Mammedov
2018-11-23 16:10 ` Michael S. Tsirkin
2018-11-26 10:21 ` Igor Mammedov
2018-11-26 10:41 ` [Qemu-devel] [PATCH v2 " Igor Mammedov
2018-11-22 10:29 ` [Qemu-devel] [PATCH 2/2] arm/virt: acpi: fix incorrect checksums in RSDP Igor Mammedov
2018-11-22 12:26 ` Andrew Jones
2018-11-23 16:11 ` Michael S. Tsirkin [this message]
2018-11-26 10:31 ` [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations Igor Mammedov
2018-11-26 10:50 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123111017-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=drjones@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).