* [Qemu-devel] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory()
@ 2018-11-22 14:31 Greg Kurz
2018-11-22 14:51 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-11-23 0:20 ` [Qemu-devel] " David Gibson
0 siblings, 2 replies; 5+ messages in thread
From: Greg Kurz @ 2018-11-22 14:31 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ppc, qemu-trivial, David Gibson
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/ppc/spapr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 9c41098b5781..7771a628f879 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -893,8 +893,6 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
/* ibm,associativity-lookup-arrays */
buf_len = (nr_nodes * 4 + 2) * sizeof(uint32_t);
cur_index = int_buf = g_malloc0(buf_len);
-
- cur_index = int_buf;
int_buf[0] = cpu_to_be32(nr_nodes);
int_buf[1] = cpu_to_be32(4); /* Number of entries per associativity list */
cur_index += 2;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory()
2018-11-22 14:31 [Qemu-devel] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory() Greg Kurz
@ 2018-11-22 14:51 ` Laurent Vivier
2018-11-23 0:20 ` [Qemu-devel] " David Gibson
1 sibling, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2018-11-22 14:51 UTC (permalink / raw)
To: Greg Kurz, qemu-devel; +Cc: qemu-trivial, qemu-ppc, David Gibson
On 22/11/2018 15:31, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> hw/ppc/spapr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 9c41098b5781..7771a628f879 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -893,8 +893,6 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
> /* ibm,associativity-lookup-arrays */
> buf_len = (nr_nodes * 4 + 2) * sizeof(uint32_t);
> cur_index = int_buf = g_malloc0(buf_len);
> -
> - cur_index = int_buf;
> int_buf[0] = cpu_to_be32(nr_nodes);
> int_buf[1] = cpu_to_be32(4); /* Number of entries per associativity list */
> cur_index += 2;
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory()
2018-11-22 14:31 [Qemu-devel] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory() Greg Kurz
2018-11-22 14:51 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2018-11-23 0:20 ` David Gibson
2018-11-23 8:04 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
1 sibling, 1 reply; 5+ messages in thread
From: David Gibson @ 2018-11-23 0:20 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-devel, qemu-ppc, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On Thu, Nov 22, 2018 at 03:31:36PM +0100, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied to ppc-for-3.2.
> ---
> hw/ppc/spapr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 9c41098b5781..7771a628f879 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -893,8 +893,6 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
> /* ibm,associativity-lookup-arrays */
> buf_len = (nr_nodes * 4 + 2) * sizeof(uint32_t);
> cur_index = int_buf = g_malloc0(buf_len);
> -
> - cur_index = int_buf;
> int_buf[0] = cpu_to_be32(nr_nodes);
> int_buf[1] = cpu_to_be32(4); /* Number of entries per associativity list */
> cur_index += 2;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory()
2018-11-23 0:20 ` [Qemu-devel] " David Gibson
@ 2018-11-23 8:04 ` Greg Kurz
2018-11-25 7:46 ` David Gibson
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kurz @ 2018-11-23 8:04 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-trivial, qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
On Fri, 23 Nov 2018 11:20:37 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Thu, Nov 22, 2018 at 03:31:36PM +0100, Greg Kurz wrote:
> > Signed-off-by: Greg Kurz <groug@kaod.org>
>
> Applied to ppc-for-3.2.
>
AFAIK, next release will be 4.0.
> > ---
> > hw/ppc/spapr.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index 9c41098b5781..7771a628f879 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -893,8 +893,6 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
> > /* ibm,associativity-lookup-arrays */
> > buf_len = (nr_nodes * 4 + 2) * sizeof(uint32_t);
> > cur_index = int_buf = g_malloc0(buf_len);
> > -
> > - cur_index = int_buf;
> > int_buf[0] = cpu_to_be32(nr_nodes);
> > int_buf[1] = cpu_to_be32(4); /* Number of entries per associativity list */
> > cur_index += 2;
> >
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory()
2018-11-23 8:04 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
@ 2018-11-25 7:46 ` David Gibson
0 siblings, 0 replies; 5+ messages in thread
From: David Gibson @ 2018-11-25 7:46 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-trivial, qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]
On Fri, Nov 23, 2018 at 09:04:19AM +0100, Greg Kurz wrote:
> On Fri, 23 Nov 2018 11:20:37 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > On Thu, Nov 22, 2018 at 03:31:36PM +0100, Greg Kurz wrote:
> > > Signed-off-by: Greg Kurz <groug@kaod.org>
> >
> > Applied to ppc-for-3.2.
> >
>
> AFAIK, next release will be 4.0.
Oh, right, I've renamed that.
>
> > > ---
> > > hw/ppc/spapr.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > > index 9c41098b5781..7771a628f879 100644
> > > --- a/hw/ppc/spapr.c
> > > +++ b/hw/ppc/spapr.c
> > > @@ -893,8 +893,6 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
> > > /* ibm,associativity-lookup-arrays */
> > > buf_len = (nr_nodes * 4 + 2) * sizeof(uint32_t);
> > > cur_index = int_buf = g_malloc0(buf_len);
> > > -
> > > - cur_index = int_buf;
> > > int_buf[0] = cpu_to_be32(nr_nodes);
> > > int_buf[1] = cpu_to_be32(4); /* Number of entries per associativity list */
> > > cur_index += 2;
> > >
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-25 7:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-22 14:31 [Qemu-devel] [PATCH] spapr: drop redundant statement in spapr_populate_drconf_memory() Greg Kurz
2018-11-22 14:51 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-11-23 0:20 ` [Qemu-devel] " David Gibson
2018-11-23 8:04 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-11-25 7:46 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).