From: Igor Mammedov <imammedo@redhat.com>
To: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: xiaoguangrong.eric@gmail.com, dan.j.williams@intel.com,
stefanha@redhat.com, pbonzini@redhat.com,
yu.c.zhang@linux.intel.com, qemu-devel@nongnu.org,
ehabkost@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message
Date: Mon, 26 Nov 2018 14:10:26 +0100 [thread overview]
Message-ID: <20181126141026.36986d6c@redhat.com> (raw)
In-Reply-To: <4773dd7667ce53e3894ac705badd6e580808c6ce.1542699775.git.yi.z.zhang@linux.intel.com>
On Tue, 20 Nov 2018 15:48:06 +0800
Zhang Yi <yi.z.zhang@linux.intel.com> wrote:
> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
>
> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> numa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
> error_report("memory backend %s is used multiple times. Each "
> "-numa option must use a different memdev value.",
> path);
> + g_free(path);
> exit(1);
> }
>
next prev parent reply other threads:[~2018-11-26 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 7:47 [Qemu-devel] [PATCH V5_resend 0/7] nvdimm: support MAP_SYNC for memory-backend-file Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message Zhang Yi
2018-11-26 13:10 ` Igor Mammedov [this message]
2018-11-29 8:41 ` Pankaj Gupta
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 2/7] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 3/7] exec: switch qemu_ram_alloc_from_{file, fd} to the " Zhang Yi
2018-11-29 9:11 ` Pankaj Gupta
2018-12-04 7:28 ` Yi Zhang
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 4/7] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 6/7] hostmem: add more information in error messages Zhang Yi
2018-11-20 7:48 ` [Qemu-devel] [PATCH V5_resend 7/7] hostmem-file: add 'sync' option Zhang Yi
2018-11-26 8:46 ` Pankaj Gupta
2018-12-04 7:32 ` Yi Zhang
2018-11-26 3:00 ` [Qemu-devel] [PATCH V5_resend 0/7] nvdimm: support MAP_SYNC for memory-backend-file Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126141026.36986d6c@redhat.com \
--to=imammedo@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).