qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Eric Blake <eblake@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	linzhecheng <linzhecheng@huawei.com>
Subject: [Qemu-devel] [PULL 5/6] usb-host: set ifs.detached as true if kernel driver is not active
Date: Tue, 27 Nov 2018 07:49:31 +0100	[thread overview]
Message-ID: <20181127064932.7299-6-kraxel@redhat.com> (raw)
In-Reply-To: <20181127064932.7299-1-kraxel@redhat.com>

From: linzhecheng <linzhecheng@huawei.com>

If no kernel driver is active, we can already claim and perform I/O on
it without detaching it.

Signed-off-by: linzhecheng <linzhecheng@huawei.com>
Message-id: 20181120083419.17716-1-linzhecheng@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/host-libusb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index f31e9cbbb8..b6602ded4e 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -1120,6 +1120,9 @@ static void usb_host_detach_kernel(USBHostDevice *s)
         rc = libusb_kernel_driver_active(s->dh, i);
         usb_host_libusb_error("libusb_kernel_driver_active", rc);
         if (rc != 1) {
+            if (rc == 0) {
+                s->ifs[i].detached = true;
+            }
             continue;
         }
         trace_usb_host_detach_kernel(s->bus_num, s->addr, i);
-- 
2.9.3

  parent reply	other threads:[~2018-11-27  6:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  6:49 [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches Gerd Hoffmann
2018-11-27  6:49 ` [Qemu-devel] [PULL 1/6] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size Gerd Hoffmann
2018-11-27  6:49 ` [Qemu-devel] [PULL 2/6] ps2kbd: default to scan enabled after reset Gerd Hoffmann
2018-11-27  6:49 ` [Qemu-devel] [PULL 3/6] cirrus_vga/migration: update the bank offset before use Gerd Hoffmann
2018-11-27  6:49 ` [Qemu-devel] [PULL 4/6] audio/hda: fix guest triggerable assert Gerd Hoffmann
2018-11-27  6:49 ` Gerd Hoffmann [this message]
2018-11-27  6:49 ` [Qemu-devel] [PULL 6/6] qapi: add query-display-options command Gerd Hoffmann
2018-11-27 14:02 ` [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches Peter Maydell
2018-11-28 23:57 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181127064932.7299-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=linzhecheng@huawei.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).