* [Qemu-devel] [PATCH] trace: simple style changes
@ 2018-11-27 19:08 Larry Dewey
2018-11-27 19:23 ` John Snow
2018-11-28 16:25 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Larry Dewey @ 2018-11-27 19:08 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, Larry Dewey
This changes two lines in simple.c that end with a comma, and replaces them
with a semi-colon.
Signed-off-by: Larry Dewey <ldewey@suse.com>
---
trace/simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index 701dec639c..ac904eca91 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -169,9 +169,9 @@ static gpointer writeout_thread(gpointer opaque)
wait_for_trace_records_available();
if (g_atomic_int_get(&dropped_events)) {
- dropped.rec.event = DROPPED_EVENT_ID,
+ dropped.rec.event = DROPPED_EVENT_ID;
dropped.rec.timestamp_ns = get_clock();
- dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t),
+ dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t);
dropped.rec.pid = trace_pid;
do {
dropped_count = g_atomic_int_get(&dropped_events);
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] trace: simple style changes
2018-11-27 19:08 [Qemu-devel] [PATCH] trace: simple style changes Larry Dewey
@ 2018-11-27 19:23 ` John Snow
2018-11-28 16:25 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2018-11-27 19:23 UTC (permalink / raw)
To: Larry Dewey, qemu-devel; +Cc: stefanha
On 11/27/18 2:08 PM, Larry Dewey wrote:
> This changes two lines in simple.c that end with a comma, and replaces them
> with a semi-colon.
>
> Signed-off-by: Larry Dewey <ldewey@suse.com>
> ---
> trace/simple.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/trace/simple.c b/trace/simple.c
> index 701dec639c..ac904eca91 100644
> --- a/trace/simple.c
> +++ b/trace/simple.c
> @@ -169,9 +169,9 @@ static gpointer writeout_thread(gpointer opaque)
> wait_for_trace_records_available();
>
> if (g_atomic_int_get(&dropped_events)) {
> - dropped.rec.event = DROPPED_EVENT_ID,
> + dropped.rec.event = DROPPED_EVENT_ID;
> dropped.rec.timestamp_ns = get_clock();
> - dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t),
> + dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t);
> dropped.rec.pid = trace_pid;
> do {
> dropped_count = g_atomic_int_get(&dropped_events);
>
I can't see any reason for why sequence points were used, other than in
62bab73213ba885426a781eb2741670b9f3cae36 getting mixed up between
if (cond) { ...; ... } and an earlier var = (type) { ..., ... }.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] trace: simple style changes
2018-11-27 19:08 [Qemu-devel] [PATCH] trace: simple style changes Larry Dewey
2018-11-27 19:23 ` John Snow
@ 2018-11-28 16:25 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2018-11-28 16:25 UTC (permalink / raw)
To: Larry Dewey; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Tue, Nov 27, 2018 at 12:08:49PM -0700, Larry Dewey wrote:
> This changes two lines in simple.c that end with a comma, and replaces them
> with a semi-colon.
>
> Signed-off-by: Larry Dewey <ldewey@suse.com>
> ---
> trace/simple.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my tracing-next tree:
https://github.com/stefanha/qemu/commits/tracing-next
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-28 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-27 19:08 [Qemu-devel] [PATCH] trace: simple style changes Larry Dewey
2018-11-27 19:23 ` John Snow
2018-11-28 16:25 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).