qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fei Li <fli@suse.com>
To: qemu-devel@nongnu.org
Cc: "Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH RFC 5/5] migration: add more error handling for postcopy_ram_enable_notify
Date: Wed, 28 Nov 2018 18:33:08 +0800	[thread overview]
Message-ID: <20181128103308.26755-6-fli@suse.com> (raw)
In-Reply-To: <20181128103308.26755-1-fli@suse.com>

Call postcopy_ram_incoming_cleanup() to do the cleanup when
postcopy_ram_enable_notify fails. Besides, report the error
message when qemu_ram_foreach_migratable_block() fails.

Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Fei Li <fli@suse.com>
---
 migration/postcopy-ram.c | 1 +
 migration/savevm.c       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index e5c02a32c5..fa09dba534 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -1117,6 +1117,7 @@ int postcopy_ram_enable_notify(MigrationIncomingState *mis)
 
     /* Mark so that we get notified of accesses to unwritten areas */
     if (qemu_ram_foreach_migratable_block(ram_block_enable_notify, mis)) {
+        error_report("ram_block_enable_notify failed");
         return -1;
     }
 
diff --git a/migration/savevm.c b/migration/savevm.c
index ef707b8c43..0d76232931 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1728,6 +1728,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
      */
     if (migrate_postcopy_ram()) {
         if (postcopy_ram_enable_notify(mis)) {
+            postcopy_ram_incoming_cleanup(mis);
             return -1;
         }
     }
-- 
2.13.7

      parent reply	other threads:[~2018-11-28 10:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 10:33 [Qemu-devel] [PATCH RFC 0/5] fix some segmentation faults and migration issues Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails Fei Li
2018-11-28 12:53   ` Markus Armbruster
2018-11-29  6:16     ` Fei Li
2018-11-29  8:35       ` Markus Armbruster
2018-11-29  9:15         ` Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 2/5] qemu_thread_join: fix segmentation fault Fei Li
2018-11-29 14:32   ` Philippe Mathieu-Daudé
2018-11-30 11:38     ` Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 3/5] migration: fix the multifd code when receiving less channels Fei Li
2018-11-28 12:17   ` Peter Xu
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup Fei Li
2018-11-28 10:33 ` Fei Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128103308.26755-6-fli@suse.com \
    --to=fli@suse.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).