From: Peter Xu <peterx@redhat.com>
To: Fei Li <fli@suse.com>
Cc: qemu-devel@nongnu.org, "Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC 3/5] migration: fix the multifd code when receiving less channels
Date: Wed, 28 Nov 2018 20:17:38 +0800 [thread overview]
Message-ID: <20181128121738.GA29246@xz-x1> (raw)
In-Reply-To: <20181128103308.26755-4-fli@suse.com>
On Wed, Nov 28, 2018 at 06:33:06PM +0800, Fei Li wrote:
> In our current code, when multifd is used during migration, if there
> is an error before the destination receives all new channels, the
> source keeps running, however the destination does not exit but keeps
> waiting until the source is killed deliberately.
>
> Fix this by dumping the specific error and let users decide whether
> to quit from the destination side when failing to receive packet via
> some channel.
>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Signed-off-by: Fei Li <fli@suse.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2018-11-28 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 10:33 [Qemu-devel] [PATCH RFC 0/5] fix some segmentation faults and migration issues Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails Fei Li
2018-11-28 12:53 ` Markus Armbruster
2018-11-29 6:16 ` Fei Li
2018-11-29 8:35 ` Markus Armbruster
2018-11-29 9:15 ` Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 2/5] qemu_thread_join: fix segmentation fault Fei Li
2018-11-29 14:32 ` Philippe Mathieu-Daudé
2018-11-30 11:38 ` Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 3/5] migration: fix the multifd code when receiving less channels Fei Li
2018-11-28 12:17 ` Peter Xu [this message]
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 5/5] migration: add more error handling for postcopy_ram_enable_notify Fei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128121738.GA29246@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fli@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).