From: Kevin Wolf <kwolf@redhat.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Anthony Perard <anthony.perard@citrix.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy
Date: Wed, 28 Nov 2018 17:19:17 +0100 [thread overview]
Message-ID: <20181128161917.GE4222@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <20181121151211.15997-3-paul.durrant@citrix.com>
Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben:
> This patch adds the basic boilerplate for a 'XenBus' object that will act
> as a parent to 'XenDevice' PV backends.
> A new 'XenBridge' object is also added to connect XenBus to the system bus.
>
> The XenBus object is instantiated by a new xen_bus_init() function called
> from the same sites as the legacy xen_be_init() function.
>
> Subsequent patches will flesh-out the functionality of these objects.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> new file mode 100644
> index 0000000000..dede2d914a
> --- /dev/null
> +++ b/hw/xen/xen-bus.c
> @@ -0,0 +1,125 @@
> +/*
> + * Copyright (c) Citrix Systems Inc.
> + * All rights reserved.
> + */
This doesn't look very compatible with the GPL. In fact it might even
make it illegal for the QEMU project to distribute this code. :-)
Other files you add throughout the series seem to have the same problem.
Kevin
next prev parent reply other threads:[~2018-11-28 16:19 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 15:11 [Qemu-devel] [PATCH 00/18] Xen PV backend 'qdevification' Paul Durrant
2018-11-21 15:11 ` [Qemu-devel] [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice Paul Durrant
2018-11-28 16:06 ` Anthony PERARD
2018-11-21 15:11 ` [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Paul Durrant
2018-11-28 16:19 ` Kevin Wolf [this message]
2018-11-28 16:26 ` [Qemu-devel] [Qemu-block] " Paul Durrant
2018-11-28 16:28 ` Paul Durrant
2018-11-28 16:28 ` Stefano Stabellini
2018-11-28 16:29 ` Paul Durrant
2018-11-28 16:39 ` Kevin Wolf
2018-11-28 16:45 ` Paul Durrant
2018-11-28 16:46 ` Paul Durrant
2018-11-29 9:04 ` Kevin Wolf
2018-11-28 17:01 ` Eric Blake
2018-11-28 17:04 ` Paul Durrant
2018-11-28 17:10 ` [Qemu-devel] " Anthony PERARD
2018-11-28 17:17 ` Paul Durrant
2018-11-28 17:32 ` Anthony PERARD
2018-11-21 15:11 ` [Qemu-devel] [PATCH 03/18] xen: introduce 'xen-qdisk' Paul Durrant
2018-11-29 16:05 ` Anthony PERARD
2018-12-04 15:20 ` Paul Durrant
2018-12-04 15:49 ` Anthony PERARD
2018-12-04 15:50 ` Paul Durrant
2018-12-04 17:14 ` Paul Durrant
2018-11-21 15:11 ` [Qemu-devel] [PATCH 04/18] xen: create xenstore areas for XenDevice-s Paul Durrant
2018-11-29 18:48 ` Anthony PERARD
2018-12-05 12:05 ` Paul Durrant
2018-12-05 12:43 ` Paul Durrant
2018-12-05 13:58 ` Anthony PERARD
2018-12-05 14:24 ` Paul Durrant
2018-12-05 16:28 ` Anthony PERARD
2018-11-21 15:11 ` [Qemu-devel] [PATCH 05/18] xen: add xenstore watcher infratructure Paul Durrant
2018-12-03 14:42 ` Anthony PERARD
2018-12-05 15:24 ` Paul Durrant
2018-11-21 15:11 ` [Qemu-devel] [PATCH 06/18] xen: add grant table interface for XenDevice-s Paul Durrant
2018-12-03 15:45 ` Anthony PERARD
2018-12-05 16:12 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 07/18] xen: add event channel " Paul Durrant
2018-12-03 16:24 ` Anthony PERARD
2018-12-04 14:24 ` Anthony PERARD
2018-12-05 16:16 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:35 ` Anthony PERARD
2018-12-03 16:42 ` Anthony PERARD
2018-11-21 15:12 ` [Qemu-devel] [PATCH 09/18] xen: remove unnecessary code from dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:58 ` Anthony PERARD
2018-11-21 15:12 ` [Qemu-devel] [PATCH 10/18] xen: add header and build dataplane/xen-qdisk.c Paul Durrant
2018-12-03 18:09 ` Anthony PERARD
2018-12-05 17:31 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Paul Durrant
2018-12-04 11:05 ` Anthony PERARD
2018-11-21 15:12 ` [Qemu-devel] [PATCH 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-qdisk.c Paul Durrant
2018-12-04 11:34 ` Anthony PERARD
2018-11-21 15:12 ` [Qemu-devel] [PATCH 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-qdisk.c Paul Durrant
2018-12-04 12:10 ` Anthony PERARD
2018-12-05 17:28 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Paul Durrant
2018-11-28 16:34 ` Kevin Wolf
2018-11-28 16:40 ` Paul Durrant
2018-11-29 9:00 ` Kevin Wolf
2018-11-29 9:33 ` Paul Durrant
2018-11-29 10:46 ` Kevin Wolf
2018-11-29 10:47 ` Paul Durrant
2018-12-04 12:33 ` Anthony PERARD
2018-12-06 12:27 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 15/18] xen: add a mechanism to automatically create XenDevice-s Paul Durrant
2018-12-04 15:35 ` Anthony PERARD
2018-12-06 12:36 ` Paul Durrant
2018-12-06 15:24 ` Anthony PERARD
2018-12-06 15:36 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 16/18] xen: automatically create XenQdiskDevice-s Paul Durrant
2018-12-04 16:40 ` Anthony PERARD
2018-12-06 13:06 ` Paul Durrant
2018-11-21 15:12 ` [Qemu-devel] [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer Paul Durrant
2018-11-27 19:05 ` Stefano Stabellini
2018-11-29 14:00 ` Philippe Mathieu-Daudé
2018-11-29 14:01 ` Paul Durrant
2018-12-04 16:42 ` Anthony PERARD
2018-11-21 15:12 ` [Qemu-devel] [PATCH 18/18] xen: remove the legacy 'xen_disk' backend Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128161917.GE4222@dhcp-200-186.str.redhat.com \
--to=kwolf@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).